Skip to content
This repository was archived by the owner on Mar 1, 2023. It is now read-only.

Allow creation of sharable retro from admin panel (fixes #308) #376

Merged
merged 1 commit into from
May 3, 2021

Conversation

textbook
Copy link
Contributor

@textbook textbook commented May 3, 2021

Thanks for contributing to postfacto. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

    • Change the name of the checkbox input for enabling the magic link to retro[is_magic_link_enabled] in the admin panel
    • Show whether a retro has the magic link enabled in the admin panel
  • An explanation of the use cases your change solves

    Allows creation of a retro with a magic link from the admin panel

  • Links to any other associated PRs

    Fixes Can't create a repo with magic link from the admin panel #308

  • I have reviewed the contributing guide

  • I have made this pull request to the master branch

  • I have run all the tests using ./test.sh.

  • I have added the copyright headers to each new file added

  • I have given myself credit in the humans.txt file (assuming I want to)

@textbook textbook merged commit be504fd into vmware-archive:master May 3, 2021
dwettstein referenced this pull request in dwettstein/postfacto Dec 15, 2021
* master:
  Bump nokogiri from 1.11.3 to 1.11.4 in /e2e (#386)
  Bump nokogiri from 1.11.3 to 1.11.4 in /api (#387)
  Bump ExecJS version
  Upgrade Rails to 6.1.3.2 (#382)
  [Snyk] Security upgrade puma from 5.2.2 to 5.3.1 (#381)
  Upgrade web dependencies (#377)
  Fix conditional push of Docker containers
  Fix typo in CI workflow
  Allow creation of sharable retro from admin panel (fixes #308) (#376)
  Overhaul Docker build, push and test (#375)
  Explicitly push all tags
  Fix the Docker push scripts (#373)
  Allow admin email and password to be overridden (fixes #369) (#371)
  Improve CONTRIBUTING.md formatting (#367) [skip ci]
  fix: upgrade mixpanel-browser from 2.39.0 to 2.41.0 (#364)
  fix: upgrade actioncable from 5.2.4 to 5.2.5 (#365)
  Remove broken gitter link (fixes #350) [skip ci]
  RFC - Attempt at making deployment docs easier to follow (#313)
  Migrate from Travis to GitHub Actions (#363)
  Upgrade all the things (#360)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create a repo with magic link from the admin panel
1 participant