Allow creation of sharable retro from admin panel (fixes #308) (#376)

Author: textbook

api/app/admin/retros.rb

@@ -70,6 +70,8 @@
 
     column('Private', :is_private)
 
+    column('Magic Link', :is_magic_link_enabled)
+
     column('User', :user)
     actions
   end
@@ -133,7 +135,7 @@
       f.input :video_link
       f.input :owner_email
       f.input :is_private
-      f.input :magic_link_enabled, as: :boolean
+      f.input :is_magic_link_enabled, as: :boolean
     end
 
     f.inputs do

api/config/locales/en.yml

@@ -72,7 +72,7 @@ en:
     labels:
       retro:
         is_private: "Make this retro private?"
-        magic_link_enabled: "Share this retro using a magic link?"
+        is_magic_link_enabled: "Share this retro using a magic link?"
         owner_email: "Owner Email"
     hints:
       retro:

api/spec/admin/admin_retros_request_spec.rb

@@ -129,6 +129,7 @@ def click_column(doc, panel_name, column_name, expected_order)
                               'Ordered By',
                               'Password',
                               'Private',
+                              'Magic Link',
                               'User'
                             ])
     end
@@ -151,6 +152,7 @@ def click_column(doc, panel_name, column_name, expected_order)
       expect(data[11]).to eq('the-video-link')
       expect(data[13]).to include('Yes')
       expect(data[14]).to include('Yes')
+      expect(data[15]).to include('No')
     end
 
     it 'has a filter for public/private retros' do

e2e.sh

@@ -119,7 +119,7 @@ popd >/dev/null
 
 pushd "$BASE_DIR/e2e" >/dev/null
   echo 'Running E2E tests...'
-  bundle exec rspec $1
+  bundle exec rspec "$@"
 popd >/dev/null
 
 # Shutdown services

e2e/spec/felicity_journey_spec.rb

@@ -252,6 +252,18 @@
     end
   end
 
+  context 'from admin panel' do
+    specify 'sharing a retro' do
+      slug = 'i-can-be-shared'
+      password = 'opensesame'
+      create_sharable_retro_as_admin(slug, password)
+      visit "#{RETRO_APP_BASE_URL}/retros/#{slug}"
+      fill_in 'Password', with: password
+      click_on 'Login'
+      expect(get_share_url).to include "/retros/#{slug}/join/"
+    end
+  end
+
   specify 'Auto facilitation journey' do
     register('felicity-auto-facilitate-user')
     create_public_retro

e2e/spec/spec_helper.rb

@@ -86,6 +86,17 @@ def add_auth_token
     page.driver.execute_script("window.localStorage.setItem('authToken', 'secret-test-user-token-ef87c521b979');")
   end
 
+  def create_sharable_retro_as_admin(slug, password)
+    login_as_admin
+    click_on 'Retros'
+    click_on 'New Retro'
+    fill_in 'Name', with: 'Sharable retro'
+    fill_in 'Slug', with: slug
+    fill_in 'Password', with: password
+    page.check 'Share this retro using a magic link?'
+    click_on 'Create Retro'
+  end
+
   def create_private_retro(team_name = nil)
     fill_in_create_retro_form(team_name)
     find('#retro_is_magic_link_enabled', visible: :all).set(true)