-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Bad words sampling parameter #9717
Merged
DarkLight1337
merged 49 commits into
vllm-project:main
from
compressa-ai:feature/bad_words_ids2
Oct 26, 2024
Merged
[Frontend] Bad words sampling parameter #9717
DarkLight1337
merged 49 commits into
vllm-project:main
from
compressa-ai:feature/bad_words_ids2
Oct 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad words ids -> Bad words
Signed-off-by: Vasily Alexeev <[email protected]>
Signed-off-by: Vasily Alexeev <[email protected]>
Signed-off-by: Vasily Alexeev <[email protected]>
Alvant
commented
Oct 26, 2024
Alvant
commented
Oct 26, 2024
Alvant
commented
Oct 26, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
DarkLight1337
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, looks good to me. Sorry for the long delay!
All's well that ends well) I'm really glad we were able to get everything sorted out quickly today. Thank you! |
Please merge from main branch to fix the CI failures. |
cooleel
pushed a commit
to cooleel/vllm
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: Shanshan Wang <[email protected]>
cooleel
pushed a commit
to cooleel/vllm
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: Shanshan Wang <[email protected]>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: qishuai <[email protected]>
rasmith
pushed a commit
to rasmith/vllm
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: Randall Smith <[email protected]>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Oct 31, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: NickLucche <[email protected]>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Oct 31, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: NickLucche <[email protected]>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
Signed-off-by: Vasily Alexeev <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For comments and discussion, see this PR: #5986.
FIX #986