Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Bad words sampling parameter #9717

Merged
merged 49 commits into from
Oct 26, 2024

Conversation

Alvant
Copy link
Contributor

@Alvant Alvant commented Oct 26, 2024

For comments and discussion, see this PR: #5986.

FIX #986

Signed-off-by: Vasily Alexeev <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, looks good to me. Sorry for the long delay!

@DarkLight1337 DarkLight1337 changed the title [Frontend] Bad words sampling parameter 2 [Frontend] Bad words sampling parameter Oct 26, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 26, 2024 12:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 26, 2024
@Alvant
Copy link
Contributor Author

Alvant commented Oct 26, 2024

In that case, looks good to me. Sorry for the long delay!

All's well that ends well)

I'm really glad we were able to get everything sorted out quickly today. Thank you!

@DarkLight1337
Copy link
Member

Please merge from main branch to fix the CI failures.

@DarkLight1337 DarkLight1337 merged commit 07e981f into vllm-project:main Oct 26, 2024
60 checks passed
cooleel pushed a commit to cooleel/vllm that referenced this pull request Oct 28, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
Signed-off-by: Shanshan Wang <[email protected]>
cooleel pushed a commit to cooleel/vllm that referenced this pull request Oct 28, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
Signed-off-by: Shanshan Wang <[email protected]>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
rasmith pushed a commit to rasmith/vllm that referenced this pull request Oct 30, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
Signed-off-by: Randall Smith <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: Vasily Alexeev <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It seems that SamplingParams doesnt support the bad_words_ids parameter when generating
2 participants