Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems that SamplingParams doesnt support the bad_words_ids parameter when generating #986

Closed
mengban opened this issue Sep 8, 2023 · 3 comments · Fixed by #9717
Closed

It seems that SamplingParams doesnt support the bad_words_ids parameter when generating #986

mengban opened this issue Sep 8, 2023 · 3 comments · Fixed by #9717
Labels
feature request good first issue Good for newcomers

Comments

@mengban
Copy link

mengban commented Sep 8, 2023

bad_words_ids described here is useful for production applications.
However It seems that vlllm doesnt support the bad_words_ids parameter when generating.
Is there a plan to support it?

  bad_words_ids(`List[List[int]]`, *optional*):
  List of list of token ids that are not allowed to be generated. Check
  [`~generation.NoBadWordsLogitsProcessor`] for further documentation and examples.
@David-Lee-1990
Copy link

any comment?

@whitepapercg
Copy link

Up

@DarkLight1337 DarkLight1337 added the good first issue Good for newcomers label Jun 2, 2024
@Alvant Alvant mentioned this issue Jun 29, 2024
Closed
@Alvant
Copy link
Contributor

Alvant commented Jun 29, 2024

I hope this can be a possible bad_words_ids stuff implementation: #5986.

@Alvant Alvant mentioned this issue Oct 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
6 participants
@mengban @Alvant @hmellor @David-Lee-1990 @DarkLight1337 @whitepapercg