Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Orion model #2539

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Support Orion model #2539

merged 10 commits into from
Feb 27, 2024

Conversation

dachengai
Copy link
Contributor

@chuanzhubin
Copy link
Contributor

加油加油

@Peter-Devine
Copy link

Much appreciated for adding this!

@kir152
Copy link

kir152 commented Jan 23, 2024

thanks for adding this

Copy link
Collaborator

@esmeetu esmeetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @dachengai. left some comments. You can also add this model in readme file.

@HanNayeoniee
Copy link

HanNayeoniee commented Feb 16, 2024

Even this work hasn't been merged yet, I tested on dachengai:orion branch.
It worked! Thanks for your contribution 😊

@Tygors
Copy link

Tygors commented Feb 20, 2024

Even this work hasn't been merged yet, I tested on dachengai:orion branch. It worked! Thanks for your contribution 😊

i wonder where dachengai:orion branch is? and how can i test this model with vllm

@HanNayeoniee
Copy link

HanNayeoniee commented Feb 20, 2024

Even this work hasn't been merged yet, I tested on dachengai:orion branch. It worked! Thanks for your contribution 😊

i wonder where dachengai:orion branch is? and how can i test this model with vllm

dachengai:orion branch is here, but i only added a few changes like model config and init shown in Files changed tab.

You can test this model by changing the model path or name to Orion!
and you can download from huggingface.

@DevXiaolan
Copy link

Much appreciated for adding this!

@Tygors
Copy link

Tygors commented Feb 21, 2024

Even this work hasn't been merged yet, I tested on dachengai:orion branch. It worked! Thanks for your contribution 😊

i wonder where dachengai:orion branch is? and how can i test this model with vllm

dachengai:orion branch is here, but i only added a few changes like model config and init shown in Files changed tab.

You can test this model by changing the model path or name to Orion! and you can download from huggingface.

many thanks, it works well for me.

@june42
Copy link

june42 commented Feb 26, 2024

Any updates?

@chuanzhubin
Copy link
Contributor

Why has it taken so long and still can't be merged in?

@WoosukKwon WoosukKwon self-requested a review February 27, 2024 03:02
@WoosukKwon WoosukKwon merged commit 48a8f4a into vllm-project:main Feb 27, 2024
9 of 13 checks passed
@WoosukKwon
Copy link
Collaborator

@esmeetu I addressed your review and updated the PR. Thanks again for the review!

xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 4, 2024
Co-authored-by: zhangdacheng <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants