Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neuron] Add custom_ops for neuron backend #13246

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

liangfu
Copy link
Contributor

@liangfu liangfu commented Feb 13, 2025

As part of the effort in supporting vLLM V1 architecture for neuron backend (#11152), this PR intent to support activation, layernorm, rotary_embedding and logits_processor as a variant of existing modules that derive from CustomOp class.

These changes are tested in individual test cases that are ported from tests/kernels directory to be neuron backend specific.

Co-authored-by: George Novack (@gnovack)
Co-authored-by: Aoyu Zhang (@AoyuQC)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@liangfu liangfu force-pushed the custom-op branch 2 times, most recently from ebef082 to ef47583 Compare February 17, 2025 22:57
@liangfu liangfu marked this pull request as ready for review February 17, 2025 22:58
@liangfu liangfu force-pushed the custom-op branch 2 times, most recently from 730bcc2 to 6b0f132 Compare February 18, 2025 07:07
Copy link

mergify bot commented Feb 21, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @liangfu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Co-authored-by: George Novack <[email protected]>
Co-authored-by: Aoyu Zhang <[email protected]>
Signed-off-by: Liangfu Chen <[email protected]>
Copy link
Contributor

@gnovack gnovack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liangfu! lgtm

@simon-mo simon-mo merged commit f75aa72 into vllm-project:main Feb 25, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants