-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neuron] Add custom_ops for neuron backend #13246
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
ebef082
to
ef47583
Compare
730bcc2
to
6b0f132
Compare
This pull request has merge conflicts that must be resolved before it can be |
Co-authored-by: George Novack <[email protected]> Co-authored-by: Aoyu Zhang <[email protected]> Signed-off-by: Liangfu Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liangfu! lgtm
As part of the effort in supporting vLLM V1 architecture for neuron backend (#11152), this PR intent to support activation, layernorm, rotary_embedding and logits_processor as a variant of existing modules that derive from CustomOp class.
These changes are tested in individual test cases that are ported from
tests/kernels
directory to be neuron backend specific.Co-authored-by: George Novack (@gnovack)
Co-authored-by: Aoyu Zhang (@AoyuQC)