Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Add support for Python 3.13 #13164

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[CI/Build] Add support for Python 3.13 #13164

wants to merge 3 commits into from

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Feb 12, 2025

FIX #12083

Dependencies that are blockers for python 3.13 support:

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 12, 2025
@mgoin mgoin marked this pull request as draft February 12, 2025 17:01
Signed-off-by: mgoin <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 12, 2025
@Ryp
Copy link

Ryp commented Feb 12, 2025

I think you'd also need a matching PR on https://github.com/vllm-project/flash-attention/blob/main/CMakeLists.txt#L22

Run locally with TORCH_CUDA_ARCH_LIST="Auto" VLLM_BUILD_DIR=build pip install -v --no-clean --no-build-isolation -e . and you should run into the error if you didn't patch this part.

Copy link

mergify bot commented Feb 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mgoin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 17, 2025
Ryp added a commit to Ryp/vllm that referenced this pull request Feb 17, 2025
This is required for vllm-project#13164 as this version has wheels for python 3.13
@Ryp Ryp mentioned this pull request Feb 17, 2025
Ryp added a commit to Ryp/vllm that referenced this pull request Feb 17, 2025
This is required for vllm-project#13164 as this version has wheels for python 3.13

Signed-off-by: Thibault Schueller <[email protected]>
@mergify mergify bot removed the needs-rebase label Feb 17, 2025
Ryp added a commit to Ryp/vllm that referenced this pull request Feb 25, 2025
This is required for vllm-project#13164 as this version has wheels for python 3.13

Signed-off-by: Thibault Schueller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support Python 3.13
2 participants