Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evalengine: Improve the timezone parsing logic #12827

Merged
merged 2 commits into from
Apr 5, 2023
Merged

evalengine: Improve the timezone parsing logic #12827

merged 2 commits into from
Apr 5, 2023

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Apr 4, 2023

While looking at supporting CONVERT_TZ in the evalengine, it was clear that our current timezone parsing didn't suffice. MySQL also supports direct UTC offsets to be used as a timezone identifier which time.LoadLocation doesn't handle.

This adds support for parsing this style of timezone offsets and a bunch of tests for this as well. It adds a separate parsing function with error so in the future we can use that in CONVERT_TZ which returns NULL on invalid timezone definitions.

Related Issue(s)

Part of implementing #9647 and something that was missed in #12742

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 4, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 4, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@dbussink dbussink force-pushed the dbussink/improve-timezone-parsing branch from e68d460 to 5baa27a Compare April 4, 2023 14:51
@github-actions github-actions bot added this to the v17.0.0 milestone Apr 4, 2023
@dbussink dbussink added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Evalengine changes to the evaluation engine and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 4, 2023
systay
systay reviewed Apr 5, 2023
View reviewed changes
go/mysql/datetime/time_zone.go
@@ -0,0 +1,63 @@
package datetime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license missing

systay
systay reviewed Apr 5, 2023
View reviewed changes
go/mysql/datetime/time_zone_test.go
@@ -0,0 +1,61 @@
package datetime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license missing

dbussink added 2 commits April 5, 2023 11:42
@dbussink
evalengine: Improve the timezone parsing logic
17fba45 
While looking at supporting `CONVERT_TZ` in the evalengine, it was clear
that our current timezone parsing didn't suffice. MySQL also supports
direct UTC offsets to be used as a timezone identifier which
`time.LoadLocation` doesn't handle.

This adds support for parsing this style of timezone offsets and a bunch
of tests for this as well. It adds a separate parsing function with
error so in the future we can use that in `CONVERT_TZ` which returns
`NULL` on invalid timezone definitions.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink
Add missing licenses
a6ddc1f 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/improve-timezone-parsing branch from 5baa27a to a6ddc1f Compare April 5, 2023 09:43
@dbussink dbussink merged commit 9eba4dd into vitessio:main Apr 5, 2023
@dbussink dbussink deleted the dbussink/improve-timezone-parsing branch April 5, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmg vmg vmg approved these changes

@systay systay systay approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: Evalengine changes to the evaluation engine Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dbussink @vmg @systay @frouioui