evalengine: Add handling for current timestamp functions #12742

dbussink · 2023-03-28T08:26:56Z

Description

This adds support for time related functions for the current date and / or time like NOW().

It also adds support for dealing with USER(), DATABASE() and VERSION().

Related Issue(s)

Part of #9647. Also helps improve the situation for issues like #12674

Checklist

"Backport to:" labels have been added if this change should be back-ported
Tests were added or are not required
Did the new or modified tests pass consistently locally and on the CI
Documentation was added or is not required

vitess-bot · 2023-03-28T08:26:59Z

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

Ensure that the Pull Request has a descriptive title.
If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

Is it really necessary to add this flag?
Flag names should be clear and intuitive (as far as possible)
Help text should be descriptive.
Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

Each item in Jobs should be named in order to mark it as required.
If the workflow should be required, the maintainer team should be notified.

Bug fixes

There should be at least one unit or end-to-end test.
The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

There should be some code comments as to why things are implemented the way they are.

New/Existing features

Should be documented, either by modifying the existing documentation or creating new documentation.
New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

Protobuf changes should be wire-compatible.
Changes to _vt tables and RPCs need to be backward compatible.
vtctl command output order should be stable and awk-able.
RPC changes should be compatible with vitess-operator
If a flag is removed, then it should also be removed from VTop, if used there.

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Vicent Marti <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>

This adds support for handling `USER()`, `DATABASE()` and `VERSION()`. The last two have fairly well defined semantics, but the first is really a best effort. `USER()` returns the effective caller id if it's set, and otherwise falls back to the default `vt_app@localhost` that Vitess uses. Today the value that is returned isn't very useful on Vitess anyway since it returns the MySQL level user. So the called id is in practice more useful already if available. Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Vicent Marti <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Vicent Marti <[email protected]>

vmg · 2023-03-29T10:16:20Z

go/vt/vtgate/evalengine/internal/datetime/spec.go

+func (spec_U) format(ctx *formatctx, b []byte) []byte {
+	panic("TODO")
+}
+
+func (spec_u) format(ctx *formatctx, b []byte) []byte {
+	panic("TODO")
+}
+
+func (spec_V) format(ctx *formatctx, b []byte) []byte {
+	panic("TODO")
+}
+
+func (spec_v) format(ctx *formatctx, b []byte) []byte {
+	_, week := ctx.t.ISOWeek()
+	return appendInt(b, week, 2)
+}
+
+func (spec_X) format(ctx *formatctx, b []byte) []byte {
+	panic("TODO")
+}


Note that these parsing specs are left as TODO because they're not being used by any of the parser code. They'll be eventually implemented when we get to DATE_FORMAT

frouioui · 2023-03-29T10:18:01Z

go/vt/vtgate/evalengine/compiler_asm_push.go

+/*
+Copyright 2023 The Vitess Authors.


dbussink requested review from harshit-gangal, systay, frouioui, GuptaManan100, shlomi-noach and vmg as code owners March 28, 2023 08:26

vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 28, 2023

dbussink force-pushed the dbussink/add-now-evalengine branch from 1b5fb0f to 0e29b63 Compare March 28, 2023 08:48

dbussink requested review from rohit-nayak-ps, arthurschreiber and mattlord as code owners March 28, 2023 08:48

dbussink force-pushed the dbussink/add-now-evalengine branch from 0e29b63 to d49f60d Compare March 28, 2023 08:56

vmg requested review from ajm188 and deepthi as code owners March 28, 2023 10:31

vmg force-pushed the dbussink/add-now-evalengine branch from 45b0d20 to 86a1731 Compare March 28, 2023 13:34

dbussink and others added 9 commits March 28, 2023 17:59

evalengine: Add handling for current timestamp functions

fafb0a2

Signed-off-by: Dirkjan Bussink <[email protected]>

evalengine: time-aware timezone functions

da933a7

Signed-off-by: Vicent Marti <[email protected]>

evalengine: fix sysdate translation

72dcd4a

Signed-off-by: Vicent Marti <[email protected]>

evalengine: implement sub-second precision formatting

54b9996

Signed-off-by: Vicent Marti <[email protected]>

sqlparser: Improve handling of time functions

06963c2

Signed-off-by: Dirkjan Bussink <[email protected]>

evalengine: Fix sysdate to honor the timezone

7f33920

Signed-off-by: Dirkjan Bussink <[email protected]>

Fix tests

e487333

Signed-off-by: Dirkjan Bussink <[email protected]>

evalengine: MySQL-compatible datetime format

83c26e4

Signed-off-by: Vicent Marti <[email protected]>

dbussink force-pushed the dbussink/add-now-evalengine branch from ddf2f5b to 83c26e4 Compare March 28, 2023 16:00

vmg and others added 3 commits March 28, 2023 18:21

evalengine: refactor vcursor

c9e5c60

Signed-off-by: Vicent Marti <[email protected]>

evalengine: add missing header

5d430ff

Signed-off-by: Vicent Marti <[email protected]>

evalengine: Fix logic for vcursor refactor

0ea12eb

Signed-off-by: Dirkjan Bussink <[email protected]>

vmg approved these changes Mar 29, 2023

View reviewed changes

vmg added 2 commits March 29, 2023 10:51

evalengine: fix execution bugs with non-constant functions

ca5f9bd

Signed-off-by: Vicent Marti <[email protected]>

evalengine: mock system timer for comparison tests

41236f1

Signed-off-by: Vicent Marti <[email protected]>

vmg reviewed Mar 29, 2023

View reviewed changes

frouioui reviewed Mar 29, 2023

View reviewed changes

go/vt/vtgate/evalengine/compiler_asm_push.go

Comment on lines +1 to +2

/*

Copyright 2023 The Vitess Authors.

Copy link

Member

frouioui Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

frouioui approved these changes Mar 29, 2023

View reviewed changes

vmg merged commit 61e66fe into vitessio:main Mar 29, 2023

vmg deleted the dbussink/add-now-evalengine branch March 29, 2023 10:19

dbussink mentioned this pull request Apr 4, 2023

evalengine: Improve the timezone parsing logic #12827

Merged

4 tasks

GuptaManan100 mentioned this pull request Dec 13, 2023

Fix accepting bind variables in time related function calls. #14763

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

evalengine: Add handling for current timestamp functions #12742

evalengine: Add handling for current timestamp functions #12742

dbussink commented Mar 28, 2023 •

edited

Loading

vitess-bot bot commented Mar 28, 2023

vmg Mar 29, 2023

frouioui Mar 29, 2023

evalengine: Add handling for current timestamp functions #12742

evalengine: Add handling for current timestamp functions #12742

Conversation

dbussink commented Mar 28, 2023 • edited Loading

Description

Related Issue(s)

Checklist

vitess-bot bot commented Mar 28, 2023

Review Checklist

General

If a new flag is being introduced:

If a workflow is added or modified:

Bug fixes

Non-trivial changes

New/Existing features

Backward compatibility

vmg Mar 29, 2023

Choose a reason for hiding this comment

frouioui Mar 29, 2023

Choose a reason for hiding this comment

dbussink commented Mar 28, 2023 •

edited

Loading