Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map controls crashing when invalid key is provided #290

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

MauricioRobayo
Copy link
Contributor

@MauricioRobayo MauricioRobayo commented Mar 31, 2024

I'm having the same issue reported on #276.

I tested it and adding optional chaining before calling indexOf fixes it, but let me know if you prefer a more verbose approach. 👍

closes #276

@usefulthink
Copy link
Collaborator

Simple and works, gotta love it :)

Thanks a lot for the fix <3

@usefulthink usefulthink merged commit 5052dfb into visgl:main Apr 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Adding <MapControl /> to a <GoogleMap /> with invalid/expired key make component crash
2 participants