fix: map controls crashing when invalid key is provided (#290)

visgl · Apr 1, 2024 · 5052dfb · 5052dfb
1 parent 5386035
commit 5052dfb
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/components/map-control.tsx b/src/components/map-control.tsx
@@ -58,7 +58,11 @@ export const MapControl = ({children, position}: MapControlProps) => {
     controls.push(controlContainer);
 
     return () => {
-      const index = controls.getArray().indexOf(controlContainer);
+      const controlsArray = controls.getArray();
+      // controlsArray could be undefined if the map is in an undefined state (e.g. invalid API-key, see #276
+      if (!controlsArray) return;
+
+      const index = controlsArray.indexOf(controlContainer);
       controls.removeAt(index);
     };
   }, [controlContainer, map, position]);