Py36 fix #4
Merged
Py36 fix #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinhkhuc
force-pushed
the
master
branch
13 times, most recently
from
cffb308 to
9ddcd81
Compare
vinhkhuc
requested changes
Jul 2, 2017
data_util.py
Outdated
| @@ -2,10 +2,15 @@ | |||
| import os | |||
| from os import path | |||
| import urllib | |||
| import urllib.request as request | |||
There was a problem hiding this comment.
Python 2 doesn't have urllib.request. This import will make the code not able to run in Python 2.
|
Good spot, let me fix this later. Thx
…Sent from my iPhone
On 2 Jul 2017, at 09:54, Vinh Khuc ***@***.***> wrote:
@vinhkhuc requested changes on this pull request.
Thanks for the PR. Looks good to me overall. Just found one small issue with it.
In data_util.py:
> @@ -2,10 +2,15 @@
import os
from os import path
import urllib
+import urllib.request as request
Python 2 doesn't have urllib.request. This import will make the code not able to run in Python 2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
fixed, import now conditional on major python version number. |
|
Great! Thank you very much. |
vinhkhuc
approved these changes
Jul 2, 2017
|
Thanks!!
…On Sun, Jul 2, 2017 at 9:16 PM, Vinh Khuc ***@***.***> wrote:
Merged #4 <#4>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG_aUSGdQB-whH1nzCguTVu2-RL-flELks5sJ_q4gaJpZM4OLcXE>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is related to #3 changes to make these scripts work for Python 3.x.
I tested these changes with
Anaconda Python 3.6.Hope this helps.
Thanks.