Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes for Python 3.x compatibility #3

Closed
esvhd opened this issue Jul 1, 2017 · 1 comment
Closed

Minor changes for Python 3.x compatibility #3

esvhd opened this issue Jul 1, 2017 · 1 comment

Comments

@esvhd
Copy link
Contributor

esvhd commented Jul 1, 2017 •
edited
Loading

Hi there,

Thanks for sharing this great set of tutorials. I made a few tiny changes to make it work for Python 3.x. Would you be interested in a pull request?

Changes:

  1. use integer division for calculating minibatch size
  2. use urllib.reqeust.urlretrieve() if python major version is > 2
  3. download MNIST files if any of the data files is missing, instead of just checking folder existence.

Thanks.
@esvhd esvhd mentioned this issue Jul 1, 2017
Merged
@vinhkhuc
Copy link
Owner

vinhkhuc commented Jul 2, 2017

Just merged. Thanks!

@vinhkhuc vinhkhuc closed this as completed Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinhkhuc @esvhd