Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMenu item spacing #35

Closed
srcarter3 opened this issue Apr 18, 2019 · 13 comments
Closed

JMenu item spacing #35

srcarter3 opened this issue Apr 18, 2019 · 13 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@srcarter3
Copy link

It would be nice if all jmenu items were spaced evenly.
Currently, JCheckBoxMenuItems have more space than other items.
menu

@vincenzopalazzo
Copy link
Owner

Can you try if this bug exists in the new jar demo?

Thanks

vincenzopalazzo added a commit that referenced this issue Apr 18, 2019
Fixed bug #34
- try fixing a bug #35
@vincenzopalazzo vincenzopalazzo self-assigned this Apr 18, 2019
@vincenzopalazzo vincenzopalazzo added the bug Something isn't working label Apr 18, 2019
@vincenzopalazzo vincenzopalazzo added this to the Version 1.0 milestone Apr 18, 2019
@vincenzopalazzo
Copy link
Owner

Hi @srcarter3,

This bus was fixed whit new jar?

Good day

@zanderson9
Copy link
Collaborator

Doesn't look like it was fixed. The spacing between JMenuCheckBox items is larger than between regular JMenu items. Please see attached image: the spacing between items "Next Place", "Recent" is smaller than between "Restore Zoom...", "Restore Projection..."

Spacing

@vincenzopalazzo
Copy link
Owner

I think the problem is with the icon because now they have the same borders with the normal items, what do you say if I try to increase the clearance between the normal items so as to put them equal?

@zanderson9
Copy link
Collaborator

I'm OK with that. The goal is to look "same" for all items, so let's try what you suggest.

@vincenzopalazzo
Copy link
Owner

I will work on it, thanks for the help

vincenzopalazzo added a commit that referenced this issue Apr 21, 2019
- Fix issue #35
- fix issue #23
- update demo swing
- Fix issue atarw/material-ui-swing#81
- Fix issue atarw/material-ui-swing#80
- Fix issue atarw/material-ui-swing#77
vincenzopalazzo added a commit that referenced this issue Apr 21, 2019
- Fixed issue #35
- Fixed issue #23
- update demo swing
- Fixed issue atarw/material-ui-swing#81
- Fixed issue atarw/material-ui-swing#80
- Fixed issue atarw/material-ui-swing#77
-Adding demo and new color propose in this issue atarw/material-ui-swing#70
@vincenzopalazzo
Copy link
Owner

I closing this issue because was fixed but I waiting a feedback

@zanderson9
Copy link
Collaborator

@vincenzopalazzo, I am using the latest jar which includes the fix for JMenu items spacing. But I am not seeing the change, i.e. the spacing between regular items is noticeably smaller than between checkbox items. Attached is the screenshot of a drop-down menu taken when using the latest jar:
menu

@vincenzopalazzo
Copy link
Owner

Hi @zanderson9,
You have changed the UIManager and added different borders to it

RadioButtonMenuItem.border
CheckBoxMenuItem.border
MenuItem.border

If yes, these edges must be the same.

If you start the demo you can see that the borders and menu items are greater than those that appear on your screen.

Let's take a test, if you haven't changed the things in the UIDefault, try adding this border

BorderFactory.createEmptyBorder(5, 0, 5, 0)

if you change the effect I'll try to see if I find the problem of the difference between the demo and your project

@zanderson9
Copy link
Collaborator

Yes, now with the addition of the borders, I see the even spacing. Yeah!

@vincenzopalazzo
Copy link
Owner

Are was get the Older setting for border in your project or the bug in to my project?

@zanderson9
Copy link
Collaborator

I added Border settings, BorderFactory.createEmptyBorder(5, 0, 5, 0), explicitly into our project for each menu item: regular item, cgheckbox item and radiobutton item.

@vincenzopalazzo
Copy link
Owner

The same configuration as the project, I close the issue because it was solved in the 1.0 beta.

Thanks for your help @zanderson9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants