Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JScrollbar mouse hover problem #77

Closed
Reap00r opened this issue Mar 29, 2019 · 23 comments · Fixed by #78
Closed

JScrollbar mouse hover problem #77

Reap00r opened this issue Mar 29, 2019 · 23 comments · Fixed by #78

Comments

@Reap00r
Copy link

Reap00r commented Mar 29, 2019

@vincenzopalazzo
I just noticed that the problem still exists that was fixed here:
#75
But this time it is for JScrollbar

@vincenzopalazzo
Copy link
Collaborator

Hi @Reap00r,

Thanks the problem is the border button, I have not noticed this before, sorry I will correct as soon as you give me more info on #73 so as to correct both

vincenzopalazzo added a commit to vincenzopalazzo/material-ui-swing that referenced this issue Mar 29, 2019
- Issue fixed atarw/material-ui-swing#73
- issue fixed atarw/material-ui-swing#77
- fixed error print the graphics in some component
- Create a component MaterialManagerListner for manager a listener for not duplicate code
vincenzopalazzo added a commit to vincenzopalazzo/material-ui-swing that referenced this issue Mar 29, 2019
- Issue fixed atarw/material-ui-swing#73
- issue fixed atarw/material-ui-swing#77
- fixed error pint the graphics in some component
- Create a component MaterialManagerListner for manager a listener for not duplicate code
vincenzopalazzo added a commit to vincenzopalazzo/material-ui-swing that referenced this issue Mar 29, 2019
- Issue fixed atarw/material-ui-swing#73
- issue fixed atarw/material-ui-swing#77
- fixed error pint the graphics in some component
- Create a component MaterialManagerListner for manager a listener for not duplicate code
@vincenzopalazzo
Copy link
Collaborator

@Reap00r I hope this bug no longer exists :)

@atarw atarw closed this as completed in #78 Mar 30, 2019
@Reap00r
Copy link
Author

Reap00r commented Apr 1, 2019

@vincenzopalazzo,
unfortunately your fix did not completely remove this bug, see the GIF
GIFScrollbar

Maybe this is related to Windows / Linux again

@vincenzopalazzo
Copy link
Collaborator

Hi @Reap00r,

Sorry for this problem, I was not able to reproduce this error and so I didn't know what nature it was, I made the same changes that I had placed in the previous components but I see that it wasn't enough.

Sorry if I can't give you a pull request where all the problems are solved, I'll work on it.
Sorry

@vincenzopalazzo
Copy link
Collaborator

Hi @Reap00r,

Before running the pull request can you test if the bug has been fixed with this version?
https://github.com/vincenzopalazzo/material-ui-swing/releases/tag/V9.9

This is an example my fix

vincenzopalazzo added a commit to vincenzopalazzo/material-ui-swing that referenced this issue Apr 1, 2019
- try fix issue atarw/material-ui-swing#77
- Work on demos, look the info in JmenuItem
@Reap00r
Copy link
Author

Reap00r commented Apr 2, 2019

Hi @vincenzopalazzo,
I just downloaded v9.9 and it is still not fixed.
I can see in your example that is seems to work, but unfortunately not for me :/
Could it be related to the color of the button (mine is blue and the border around the scrollbar turns blue as well)

@vincenzopalazzo
Copy link
Collaborator

@Reap00r,

Very probable that the bug is not in the jscrollbar but in the mouse hover effect, I will try to look at the code and propose a new solution, unfortunately when I release the solution you'll have to act as a tester :) since I can't reproduce your error on Windows and Linux.

@Reap00r
Copy link
Author

Reap00r commented Apr 2, 2019

Hi @vincenzopalazzo,

no problem. Just tell me when you got an update and I will test it asap ;)

@vincenzopalazzo
Copy link
Collaborator

Hi @Reap00r,

I released another fix for this problem, I introduce a new component MaterialUIStaticMoviment , this component haven't a wake effect, it was thought for the effect mouse hover on the button for component static, an example: JSpinner, JScrollBar, KComboBox.

The version fixed (I hope)

I attend your feedback for creating an official pull request :)

@Reap00r
Copy link
Author

Reap00r commented Apr 8, 2019

Hi @vincenzopalazzo,

unfortunately this is still not fixed. I didn't have a closer look into the code changes, but I saw that you added a swing set to your new version. Would this be necessary for the fix?
See my test results here:
GIFScrollbar
GIFScrollbar2

@vincenzopalazzo
Copy link
Collaborator

vincenzopalazzo commented Apr 8, 2019

@atarw can you reopen this issue, please?

Hi @Reap00r,
The swing set is the first version demo for this theme, it's not necessary for the function od the look and feel.

Before refactoring the code I would like to ask you about things, in this version a good rule was introduced, before creating new effects with MaterialUIMoviment you have to clean up all the listeners.
So I will now ask you if you have added new effects to any buttons because if it were so could you kindly use this code before adding the mouse hover effect to the button?

MaterialManagerListener. removeAllMouseListener(yourButton);
yourButton.addMouseListener(MaterialUIMovement.getMovement(yourButton, MaterialColors.YOUR_COLOR));

if you added the listener whit MaterialUiMovement, try this code.

Yesterday I added a new fix into look and feel (the brach atarw) for problem pixeled font, If you have time can you tell me even if the fix has paid off?

I attend your feedback

@Reap00r
Copy link
Author

Reap00r commented Apr 8, 2019

Hi @vincenzopalazzo,

at first I pulled the latest changed and tried the new version but it still didn't work.

Now I tried a few things:
At first, this is the current version:
GIFScrollpaneBroken

Now I removed the All the mouse listeners as you mentioned (WITHOUT adding one)
GIFRemovingMouselisteners

Now I removed them and added one (note that the button with the icon to the right was NOT changed, but I was testing it with the button on top)
GIFScrollpaneAfterRemove

I hope that helps

@vincenzopalazzo
Copy link
Collaborator

Thanks, @Reap00r,

in this example, the effect is wrong, right?

Now I removed the All the mouse listeners as you mentioned (WITHOUT adding one)

Thanks for this example and another question, you have change a color mouse hover with the LITE_BLUE? if you change the mouse hover color on button into equals color mouse hover JScroll bar you have a Effect OK, right?

@Reap00r
Copy link
Author

Reap00r commented Apr 8, 2019

Hi @vincenzopalazzo,

in all of my examples the effect is wrong. it should stay gray without the strange border.

Even changing the button hovercolor to grey, it still get partly painted in blue (maybe cause of the normal color of the button)
I am pretty sure this is related to the color the buttons / icons have that I recently hovered or I will hover over before/after leaving.
GIFScrollpaneBroken2

@atarw atarw reopened this Apr 8, 2019
vincenzopalazzo referenced this issue in vincenzopalazzo/material-ui-swing Apr 8, 2019
- Fix MouseListner jSpinner
- try fix issue #77 with repaint new border
- added new color for version 1.0
@vincenzopalazzo
Copy link
Collaborator

@Reap00r I repaint new border, try this version and if it's work I will create a pull request
This is version https://github.com/vincenzopalazzo/material-ui-swing/releases/tag/V9.9

@Reap00r
Copy link
Author

Reap00r commented Apr 9, 2019

Hi @vincenzopalazzo,
I tried your version and it still doesn't work unfortunately. In my test I didn't remove all the mouse listeners, because I wouldn't be able to handle this in my project.
GIFScrollpaneBroken3

@vincenzopalazzo
Copy link
Collaborator

Hi @Reap00r,

I added new change, you try it https://github.com/vincenzopalazzo/material-ui-swing/releases/tag/V9.9
if the error persists, I will create a version for debugging your application so by analyzing the output we will be able to understand what's wrong, in the meantime I have removed the BasicButtonArrow and I set the icons manually, try and let me know

@Reap00r
Copy link
Author

Reap00r commented Apr 9, 2019

Hi @vincenzopalazzo,
just to be sure I am doing this stuff right. When I click on the link you provided, I see this:
vincenzopalazzo released this 11 days ago
Now when I download your asset (material ui design), is this the latest version?

Since I was not sure about that I cloned your project and build the version myself today in the morning.
Now I tried to pull and build it myself but there were no changes that I could pull.

Thanks for helping me figuring that out

@vincenzopalazzo
Copy link
Collaborator

Hi @Reap00r,

The jar should be the one I loaded, but to avoid working on projects that are not up to date I will now commit the latest version, which you can easily build the jar with maven

vincenzopalazzo referenced this issue in vincenzopalazzo/material-ui-swing Apr 9, 2019
@vincenzopalazzo
Copy link
Collaborator

@Reap00r the version are online, I attend your feedback :)

@Reap00r
Copy link
Author

Reap00r commented Apr 9, 2019

@vincenzopalazzo,
hopefully I wasn't the problem all along.
I just saw that I used your fixedsomeissue branch and not the master and maybe that's the reason why your changes didn't work.. maybe because they were not in my version?!

Well.. anyway.. with the master branch it is WORKING :D

Great work and thanks for your help as always!

@vincenzopalazzo
Copy link
Collaborator

vincenzopalazzo commented Apr 9, 2019

@Reap00r The branch fixedsomeissue is the version allineated with atawr, the branch master is the my version.

Well, I'm happy of the my last change worked, the problem was the ButtonArrow, because paint the her border, now the ButtonArrow is remove.

I will create a pull request when I'm fixing this issues

Thank you for help me learning

Great work and thanks for your help as always!

vincenzopalazzo added a commit to vincenzopalazzo/material-ui-swing that referenced this issue Apr 21, 2019
- Fix issue #35
- fix issue #23
- update demo swing
- Fix issue atarw/material-ui-swing#81
- Fix issue atarw/material-ui-swing#80
- Fix issue atarw/material-ui-swing#77
vincenzopalazzo added a commit to vincenzopalazzo/material-ui-swing that referenced this issue Apr 21, 2019
- Fixed issue #35
- Fixed issue #23
- update demo swing
- Fixed issue atarw/material-ui-swing#81
- Fixed issue atarw/material-ui-swing#80
- Fixed issue atarw/material-ui-swing#77
-Adding demo and new color propose in this issue atarw/material-ui-swing#70
@vincenzopalazzo
Copy link
Collaborator

Now I Creating a pull request, the pull request resolve this problem, @atarw can you close this issue, please?

@atarw atarw closed this as completed Apr 21, 2019
mikera pushed a commit to nuroko/material-ui-swing that referenced this issue Apr 29, 2020
Update the license and try to add "used by" with gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants