Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact Script not updated #503

Closed
frog23 opened this issue May 10, 2013 · 1 comment
Closed

Compact Script not updated #503

frog23 opened this issue May 10, 2013 · 1 comment

Comments

@frog23
Copy link

frog23 commented May 10, 2013

In the downloadable code from video.js (http://www.videojs.com/downloads/video-js-4.0.0.zip), the compact version of the script (video-js/video.js) is either defect or not up to date or both. With it, it is possible to select the player, still using the old V ("video-id") syntax, as well as the new videojs("video-id"). However it also appears to be missing some functions. For example requestFullScreen() and cancelFullScreen() are not available. I haven't checked the other functions though.

@heff
Copy link
Member

heff commented May 10, 2013

Those two items are probably missing from the exports file, so that they don't get mangled in magnification.
https://github.com/videojs/video.js/blob/master/src/js/exports.js

If so, want to put together a pull request for those?

On May 10, 2013, at 7:43 AM, frog23 [email protected] wrote:

In the downloadable code from video.js (http://www.videojs.com/downloads/video-js-4.0.0.zip), the compact version of the script (video-js/video.js) is either defect or not up to date or both. With it, it is possible to select the player, still using the old V ("video-id") syntax, as well as the new videojs("video-id"). However it also appears to be missing some functions. For example requestFullScreen() and cancelFullScreen() are not available. I haven't checked the other functions though.


Reply to this email directly or view it on GitHub.

heff added a commit to heff/video.js that referenced this issue Jun 3, 2013
…ixes videojs#503

Other html5 video properties are covered by closure compiler's internal exports set, but not the fullscreen options which are still being designed/approved by w3c.
@mmcc mmcc closed this as completed Feb 22, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants