-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requestFullScreen() does not work #279
Comments
After some tests, the production version of the source doesn't contain the requestFullScreen() method, while the dev do. Try using this one. |
…ixes videojs#503 Other html5 video properties are covered by closure compiler's internal exports set, but not the fullscreen options which are still being designed/approved by w3c.
Thanks! It's working now 👍 |
Great! |
Hey heff, Is that fix in the 4.0.4 release of video.js ? I can't find it in the video.js/ video.dev.js file. Thx |
No, not yet. It'll go out with 4.1. It is in master though. |
What is the eta for 4.1? |
I think next week. On Jun 27, 2013, at 11:16 AM, Casey Jensen [email protected] wrote:
|
Great, thanks Steve. I'm looking forward to seeing this resolved. |
Hi Steve. I've downloaded the 4.1 update, and am including the call, but it still appears to not work. The call I'm using is:
I've tried this in a variety of browsers (Chrome, Safari, MobileSafari), but none seem to work. Can you explain what I'm missing here? Cheers. |
any updates on the issue since its still not working for me "video.js": "^6.6.3",
|
@vakuzmin the browsers require that requestFullscreen be called as part of a user gesture. |
@gkatsev ahh i see, thanks a lot for the getting back |
PSA: note the capital This took me a while to figure out |
my working example https://codepen.io/galgurevich/pen/JjMqXGO https://codepen.io/galgurevich/pen/oNpRxGP player.on("play", function(){ should work |
In Chrome 23.0.1271.97 no matter what I try, calling
requestFullScreen()
does not work! The fullscreen button on the controls works as expected and opens the video in fullscreen however callingrequestFullScreen()
does nothing. Calling it does set theisFullscreen
to true but does nothing.The text was updated successfully, but these errors were encountered: