This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Adds unit tests #41
Merged
Adds unit tests #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also makes some minor docstring changes to datatypes * also updates some dependencies
* also updates docstrings in datatypes
updates unit tests after deletion of old interface
New Interface for Factor Graph Model Building (#53)
* ci now uses pytest-cov to generate reports * removes coverage requirement from poetry dev reqs * small update to codecov yml
Merging after heretic model incorporation
* gets 100% coverage for nodes.py * updates poetry to depend on strictly python 3.7 (others cause problems with pre-commit, etc.) * minor update to gitignore
* updates ci to run correct testing command * suppresses coverage checking for certain functions that cannot possibly be run (in groups.py)
|
Coverage is now 100% - ready for review and potential merging! Note that I had to tell |
StannisZhou
reviewed
Aug 24, 2021
StannisZhou
approved these changes
Aug 25, 2021
Co-authored-by: Guangyao Zhou <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes 1 E2E test, as well as a few files with basic tests for some of our other functionalities. These other tests are incomplete and intended to show a proposal for how we might structure all our test files. Would love to get feedback on (1) test structuring and (2) which files/functions we should create tests for, and which ones will just be unnecessary
Resolves #11