Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Test sanity check example using new interface and inference modules, and put together the first unit test #11

Closed
StannisZhou opened this issue Jul 14, 2021 · 6 comments · Fixed by #41
Assignees
Milestone

Comments

@StannisZhou
Copy link
Contributor

StannisZhou commented Jul 14, 2021

The unit test should run fast. One option is to cache new results. Another option is to just make the model really small.

In the process, we should also:

  1. Deprecate the current contrib module and create a new examples directory to hold everything.
  2. Start figuring out what our user facing interface should look like.
@NishanthJKumar
Copy link
Contributor

NishanthJKumar commented Jul 14, 2021

Just managed to get all the data structures compiled for the 150 x 150 sanity_check example. Looks like it takes 7-9s, whereas the previous naive data-structure compiler took ~5s... Not sure why this is happening - perhaps we should parallelize the new compiler and see? (if you're interested in trying for yourself, notebook is on the sanity_check branch of my fork, under the examples folder)

@StannisZhou
Copy link
Contributor Author

StannisZhou commented Jul 14, 2021

But I remember for 150x150 examples previously compiling takes about 18s (for the flat implementation). Are you talking about the flat implementation? I can also take a look at the actual code. This implementation is easily parallelizable but even without parallelization I feel it should be at least as fast.....

@NishanthJKumar
Copy link
Contributor

That was for a previous iteration of the compiling code. I refactored it to be faster for the optimized fully-flat implementation. I just tried it and it takes ~6s (test_notebooks/sanity_check_optimize_mpbp_unpadded.py is the test notebook)

@StannisZhou
Copy link
Contributor Author

Tracking the issue in #18

@StannisZhou
Copy link
Contributor Author

We can consider adding something like https://github.com/marketplace/codecov to guide our unit test process

@StannisZhou
Copy link
Contributor Author

Closed via #53

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants