Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Changes for blog post #109

Merged
merged 10 commits into from
Jan 4, 2022
Merged

Changes for blog post #109

merged 10 commits into from
Jan 4, 2022

Conversation

StannisZhou
Copy link
Contributor

@StannisZhou StannisZhou commented Jan 4, 2022

Included a few naming updates: variable_size -> num_state, connected_variable_names -> variable_name_for_factors.

Updates on example notebooks from blog post writing.

Fixed a bug in factor group broadcasting.

Resolves #62. Resolves #66 (with the updated RBM example notebook). Resolves #105.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #109 (29b3675) into master (aa3ff5f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #109   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          640       640           
=========================================
  Hits           640       640           
Impacted Files Coverage Δ
pgmax/fg/graph.py 100.00% <ø> (ø)
pgmax/fg/groups.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3ff5f...29b3675. Read the comment docs.

Copy link
Contributor

@NishanthJKumar NishanthJKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StannisZhou StannisZhou merged commit 09f57aa into vicariousinc:master Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants