Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Naming improvements #105

Closed
StannisZhou opened this issue Dec 8, 2021 · 0 comments · Fixed by #109
Closed

Naming improvements #105

StannisZhou opened this issue Dec 8, 2021 · 0 comments · Fixed by #109
Milestone
0.2.2

Comments

@StannisZhou
Copy link
Contributor

From @swaroopgj : variable_size is confusing.

From @lazarox :

  • The number of categories of a variable I think is sometimes called num_states, but when creating a grid of variables, they are called variable_size
  • In the internal wiring, I think you call them edges_num_states, so now it seems to be a property of the edges and not the variables.
@StannisZhou StannisZhou added this to the 0.2.2 milestone Dec 8, 2021
@StannisZhou StannisZhou mentioned this issue Jan 4, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.2
Development

Successfully merging a pull request may close this issue.

Changes for blog post StannisZhou/PGMax
1 participant
@StannisZhou