Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lack of duration in thrift Value definition. #3546

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Fix lack of duration in thrift Value definition. #3546

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74fc214
Fix lack of duration in thrift Value definition.
Shylock-Hg Dec 23, 2021
77e24fb
Merge branch 'master' into feature/duration-interface
yixinglu Dec 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/interface/common.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ union Value {
14: NSet (cpp.type = "nebula::Set") uVal (cpp.ref_type = "unique");
15: DataSet (cpp.type = "nebula::DataSet") gVal (cpp.ref_type = "unique");
16: Geography (cpp.type = "nebula::Geography") ggVal (cpp.ref_type = "unique");
17: Duration (cpp.type = "nebula::Duration") duVal (cpp.ref_type = "unique");
} (cpp.type = "nebula::Value")


Expand Down Expand Up @@ -226,6 +227,8 @@ struct KeyValue {
2: binary value,
} (cpp.type = "nebula::KeyValue")

// !! Struct Duration has a shadow data type defined in the Duration.h
// So any change here needs to be reflected to the shadow type there
struct Duration {
1: i64 seconds;
2: i32 microseconds;
Expand Down