Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lack of duration in thrift Value definition. #3546

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Fix lack of duration in thrift Value definition. #3546

merged 2 commits into from
Dec 25, 2021

Conversation

Shylock-Hg
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Dec 23, 2021
@jievince jievince requested review from Aiee and Nicole00 December 23, 2021 06:15
@Shylock-Hg Shylock-Hg added this to the v3.0.0 milestone Dec 23, 2021
@yixinglu yixinglu removed the LGTM2 label Dec 25, 2021
@yixinglu yixinglu merged commit 6e13518 into vesoft-inc:master Dec 25, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 1, 2022
Closed
@Shylock-Hg Shylock-Hg deleted the feature/duration-interface branch February 9, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiee Aiee Aiee approved these changes

@jievince jievince jievince approved these changes

@czpmango czpmango Awaiting requested review from czpmango

@Nicole00 Nicole00 Awaiting requested review from Nicole00

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Shylock-Hg @Aiee @jievince @yixinglu @Sophie-Xie