-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Raft] make me crazy #3172
[Raft] make me crazy #3172
Conversation
08cd286
to
cef4526
Compare
e37c4f9
to
65c2997
Compare
…ogIdToSend_ - 1;" * do not send pending wals when leader is sending a snapshot * unify E_LOG_GAP and E_LOG_STALE
* unify SUCCEEDED E_LOG_GAP E_LOG_STALE
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #3172 +/- ##
==========================================
+ Coverage 85.20% 85.23% +0.02%
==========================================
Files 1304 1288 -16
Lines 119897 119876 -21
==========================================
+ Hits 102164 102173 +9
+ Misses 17733 17703 -30
Continue to review full report at Codecov.
|
Origins from and rely on #3031, some code may be conflicted as well, wait that merge first.
Change notes:
magic code
), for example:and many
Host
has been unified. I will describe the invariant later.Todo:
Host
when appendLogs, but it seems failed (crashed a lot), still working on it.