only wait rpc time in Host::reset

vesoft-inc · Oct 26, 2021 · e37c4f9 · e37c4f9
1 parent e8c20eb
commit e37c4f9
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 11 deletions.
diff --git a/src/kvstore/raftex/Host.cpp b/src/kvstore/raftex/Host.cpp
@@ -36,6 +36,26 @@ Host::Host(const HostAddr& addr, std::shared_ptr<RaftPart> part, bool isLearner)
           "%s[Host: %s:%d] ", part_->idStr_.c_str(), addr_.host.c_str(), addr_.port)),
       cachingPromise_(folly::SharedPromise<cpp2::AppendLogResponse>()) {}
 
+void Host::reset() {
+  std::unique_lock<std::mutex> g(lock_);
+  LOG(WARNING) << idStr_ << "wtf " << requestOnGoing_;
+  bool ongoing = noMoreRequestCV_.wait_for(
+      g, std::chrono::milliseconds(FLAGS_raft_rpc_timeout_ms << 1), [this] {
+        return !requestOnGoing_;
+      });
+  if (ongoing) {
+    LOG(WARNING) << idStr_ << "!requestOnGoing_ is still false after wait";
+    requestOnGoing_ = false;
+  }
+  logIdToSend_ = 0;
+  logTermToSend_ = 0;
+  lastLogIdSent_ = 0;
+  lastLogTermSent_ = 0;
+  committedLogId_ = 0;
+  sendingSnapshot_ = false;
+  followerCommittedLogId_ = 0;
+}
+
 void Host::waitForStop() {
   std::unique_lock<std::mutex> g(lock_);
 

diff --git a/src/kvstore/raftex/Host.h b/src/kvstore/raftex/Host.h
@@ -39,17 +39,8 @@ class Host final : public std::enable_shared_from_this<Host> {
     stopped_ = true;
   }
 
-  void reset() {
-    std::unique_lock<std::mutex> g(lock_);
-    noMoreRequestCV_.wait(g, [this] { return !requestOnGoing_; });
-    logIdToSend_ = 0;
-    logTermToSend_ = 0;
-    lastLogIdSent_ = 0;
-    lastLogTermSent_ = 0;
-    committedLogId_ = 0;
-    sendingSnapshot_ = false;
-    followerCommittedLogId_ = 0;
-  }
+  // only invoked from RaftPart
+  void reset();
 
   void waitForStop();