Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added generated files to gitignore #1458

Merged
merged 4 commits into from
Oct 10, 2020
Merged

added generated files to gitignore #1458

merged 4 commits into from
Oct 10, 2020

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented Oct 5, 2020

Added some generated files to gitignore. closes #1438

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #1458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1458   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1275     1275           
=======================================
  Hits         1274     1274           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d61d4c...db8b497. Read the comment docs.

@rubiin
Copy link
Member Author

rubiin commented Oct 6, 2020

@profnandaa @ezkemboi

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rubiin
Thank you for taking the time to fix this issue, i think that you also need to delete those files from the repo

@rubiin
Copy link
Member Author

rubiin commented Oct 6, 2020

Sure

@rubiin
Copy link
Member Author

rubiin commented Oct 8, 2020

@profnandaa any updates on this one. Would be handy for contributors and will stop the prs from getting messier

@profnandaa
Copy link
Member

Sure, sorry. could you also stage the deletion of the respective directories as part of this PR?

@rubiin
Copy link
Member Author

rubiin commented Oct 8, 2020

sure

@rubiin
Copy link
Member Author

rubiin commented Oct 8, 2020

@profnandaa done

@@ -5,3 +5,5 @@ coverage.lcov
.nyc_output
package-lock.json
yarn.lock
es
lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you left out validator.js and validator.min.js; I was actually a little split on whether we should gitignore these. I think I'm okay with this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they should be left in. Users can then grab one of them for their front-end assets without having to build it from scratch.

@profnandaa
Copy link
Member

profnandaa commented Oct 9, 2020

@chriso -- please have a look at this. I'm sure at some point you must have considered this and there are reason why you left it that way.

@chriso
Copy link
Collaborator

chriso commented Oct 9, 2020

LGTM

@rubiin
Copy link
Member Author

rubiin commented Oct 10, 2020

Hello @rubiin
Thank you for taking the time to fix this issue, i think that you also need to delete those files from the repo

can you review @tux-tn

@profnandaa profnandaa merged commit 9deb629 into validatorjs:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated files should be gitignored.
4 participants