-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added generated files to gitignore #1458
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1458 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1275 1275
=======================================
Hits 1274 1274
Misses 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rubiin
Thank you for taking the time to fix this issue, i think that you also need to delete those files from the repo
Sure |
@profnandaa any updates on this one. Would be handy for contributors and will stop the prs from getting messier |
Sure, sorry. could you also stage the deletion of the respective directories as part of this PR? |
sure |
@profnandaa done |
@@ -5,3 +5,5 @@ coverage.lcov | |||
.nyc_output | |||
package-lock.json | |||
yarn.lock | |||
es | |||
lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you left out validator.js
and validator.min.js
; I was actually a little split on whether we should gitignore these. I think I'm okay with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they should be left in. Users can then grab one of them for their front-end assets without having to build it from scratch.
@chriso -- please have a look at this. I'm sure at some point you must have considered this and there are reason why you left it that way. |
LGTM |
Added some generated files to gitignore. closes #1438
Checklist