Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated files should be gitignored. #1438

Closed
saidfagan opened this issue Sep 16, 2020 · 6 comments · Fixed by #1458
Closed

Generated files should be gitignored. #1438

saidfagan opened this issue Sep 16, 2020 · 6 comments · Fixed by #1458

Comments

@saidfagan
Copy link
Contributor

When I run npm test lots of files get modified. Excluding these files from commit is unnecessary work. I think, these files should be placed in some directory (e.g. build) and gitignored.

@rubiin
Copy link
Member

rubiin commented Sep 28, 2020

@profnandaa should we check this?

@profnandaa
Copy link
Member

@rubiin -- open to ideas.

@rubiin
Copy link
Member

rubiin commented Sep 30, 2020

i think i can spare a time for these

@rubiin
Copy link
Member

rubiin commented Sep 30, 2020

I have created a pr for this @profnandaa .I also struggled with this in my past Prs where non necessary generated files were accidently commited. I think this will keep that at bay #1450

@tux-tn
Copy link
Member

tux-tn commented Oct 1, 2020

I strongly agree with this 👍

@ezkemboi
Copy link
Member

ezkemboi commented Oct 2, 2020

I also agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants