-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated files should be gitignored. #1438
Labels
Comments
@profnandaa should we check this? |
@rubiin -- open to ideas. |
i think i can spare a time for these |
I have created a pr for this @profnandaa .I also struggled with this in my past Prs where non necessary generated files were accidently commited. I think this will keep that at bay #1450 |
I strongly agree with this 👍 |
I also agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I run
npm test
lots of files get modified. Excluding these files from commit is unnecessary work. I think, these files should be placed in some directory (e.g.build
) and gitignored.The text was updated successfully, but these errors were encountered: