Replace define-assembly for include-all with assembly ref
#1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-waltermire
suggested changes
Feb 25, 2022
There was a problem hiding this comment.
@guyzyl This looks good. Can you clean up the closing tags?
david-waltermire
force-pushed
the
fix-1137
branch
from
81d9992 to
f1c038c
Compare
david-waltermire
approved these changes
Feb 25, 2022
david-waltermire
force-pushed
the
release-1.0
branch
from
0b23c6d to
907985b
Compare
david-waltermire
force-pushed
the
fix-1137
branch
from
61db281 to
ffccf73
Compare
… proper importing.
david-waltermire
added a commit
that referenced
this pull request
Feb 26, 2022
* Replace `define-assembly` for `include-all` with `assembly ref` * Apply suggestions from code review * Moved include-all to oscal_control-common_metaschema.xml to allow for proper importing. Resolves #1137 Co-authored-by: David Waltermire <[email protected]>
@david-waltermire-nist sorry, I was on vacation and didn't see your request until now :) |
|
@guyzyl No need to apologize. I hope you enjoyed your time off. Thanks for all the contributions. |
stephenbanghart
pushed a commit
to stephenbanghart/OSCAL
that referenced
this pull request
Mar 14, 2022
…stgov#1144) * Replace `define-assembly` for `include-all` with `assembly ref` * Apply suggestions from code review * Moved include-all to oscal_control-common_metaschema.xml to allow for proper importing. Resolves usnistgov#1137 Co-authored-by: David Waltermire <[email protected]>
iMichaela
pushed a commit
to iMichaela/OSCAL
that referenced
this pull request
Apr 7, 2022
…stgov#1144) * Replace `define-assembly` for `include-all` with `assembly ref` * Apply suggestions from code review * Moved include-all to oscal_control-common_metaschema.xml to allow for proper importing. Resolves usnistgov#1137 Co-authored-by: David Waltermire <[email protected]>
Rene2mt
pushed a commit
to Rene2mt/OSCAL
that referenced
this pull request
May 17, 2022
…stgov#1144) * Replace `define-assembly` for `include-all` with `assembly ref` * Apply suggestions from code review * Moved include-all to oscal_control-common_metaschema.xml to allow for proper importing. Resolves usnistgov#1137 Co-authored-by: David Waltermire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Updated the
include-allfields in the assessment metaschema to arefto the profile instead ofdefine-assemblyThis fixes issue #1137, see full explanation there.
All Submissions: