-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include-all
type mismatch between Profile and Assessment Plan
#1137
Comments
4 tasks
david-waltermire
pushed a commit
to guyzyl/OSCAL
that referenced
this issue
Feb 25, 2022
david-waltermire
pushed a commit
to guyzyl/OSCAL
that referenced
this issue
Feb 26, 2022
david-waltermire
added a commit
that referenced
this issue
Feb 26, 2022
* Replace `define-assembly` for `include-all` with `assembly ref` * Apply suggestions from code review * Moved include-all to oscal_control-common_metaschema.xml to allow for proper importing. Resolves #1137 Co-authored-by: David Waltermire <[email protected]>
stephenbanghart
pushed a commit
to stephenbanghart/OSCAL
that referenced
this issue
Mar 14, 2022
…stgov#1144) * Replace `define-assembly` for `include-all` with `assembly ref` * Apply suggestions from code review * Moved include-all to oscal_control-common_metaschema.xml to allow for proper importing. Resolves usnistgov#1137 Co-authored-by: David Waltermire <[email protected]>
iMichaela
pushed a commit
to iMichaela/OSCAL
that referenced
this issue
Apr 7, 2022
…stgov#1144) * Replace `define-assembly` for `include-all` with `assembly ref` * Apply suggestions from code review * Moved include-all to oscal_control-common_metaschema.xml to allow for proper importing. Resolves usnistgov#1137 Co-authored-by: David Waltermire <[email protected]>
Rene2mt
pushed a commit
to Rene2mt/OSCAL
that referenced
this issue
May 17, 2022
…stgov#1144) * Replace `define-assembly` for `include-all` with `assembly ref` * Apply suggestions from code review * Moved include-all to oscal_control-common_metaschema.xml to allow for proper importing. Resolves usnistgov#1137 Co-authored-by: David Waltermire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Both the Profile and the Assessment Plan schemas have models that contain an
include-all
field.In the Profile schema they are:
#assembly_oscal-profile_insert-controls
#assembly_oscal-profile_import
In Assessment Plan they are:
#assembly_oscal-assessment-common_reviewed-controls.control-selection
#assembly_oscal-assessment-common_reviewed-controls.control-objective-selections
#assembly_oscal-assessment-common_assessment-subject
The problem is that there's a mismatch in the
include-all
field's types between the Profile and Assessment Plan.In the Profile schema they are of type
#assembly_oscal-profile_include-all
, compared to Assessment Plan where they defined asobject
.The solution to this issue is to convert the Assessment Plan's
include-all
fields to be of type#assembly_oscal-profile_include-all
.Since they're currently accepting type
object
and#assembly_oscal-profile_include-all
is anobject
, this solution is backwards compatible.Expected behavior (i.e. solution)
Uniformal types between the different OSCAL layers.
Other Comments
I'd be more than happy to open a PR for this in case this bug gets "accepted".
The text was updated successfully, but these errors were encountered: