Enable debug info with flag in command build #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think as long as it is still guaranteed that non- |
clearloop
commented
Jan 6, 2021
Comment on lines
+141
to
+146
| let mut flags = | ||
| "-C link-arg=-z -C link-arg=stack-size=65536 -C link-arg=--import-memory".to_string(); | ||
| if debug { | ||
| flags.push_str(" -C opt-level=1"); | ||
| } | ||
| std::env::set_var("RUSTFLAGS", flags); |
There was a problem hiding this comment.
Not sure using the rustc flag or building debug wasm binary under --debug
clearloop
commented
Jan 6, 2021
| @@ -339,30 +375,32 @@ pub(crate) fn execute_with_crate_metadata( | |||
| optimize_contract: bool, | |||
| build_artifact: BuildArtifacts, | |||
| unstable_flags: UnstableFlags, | |||
| ) -> Result<(Option<PathBuf>, Option<OptimizationResult>)> { | |||
| debug: bool, | |||
| ) -> Result<(Option<PathBuf>, Option<PathBuf>, Option<OptimizationResult>)> { | |||
There was a problem hiding this comment.
This modification is quite dirty, would you mind offering some advice if this PR is welcome in the next days? @Robbepop
The code in this PR is a mess, it works, but I'm not satisfied even myself.
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
Currently
cargo-contracttrimsname sectionby default while building contracts,strip_custom_sections,wasm-optand an operation inparity-wasm(paritytech/parity-wasm#300) will removename section, which makes it hard to debug contracts.We are trying to set up a flag
--debugto keepname sectionin this PR, we have kept thename sectionafterstrip_custom_sectionsbut not inwasm_opt(not sure if it is a bug,name sectionoptimized even passingdebug_info: truetobinaryen, butwasm-optworks fine using the same arguments in command-linewasm-opt -O3 -s 1 --debuginfo contract.wasm)Instead, we left
target/ink/<contract>.src.wasmafter the process, which contains name section.Refs
#169