Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give contract authors control over optimization passes #169

Closed
1 task
cmichi opened this issue Feb 4, 2021 · 2 comments
Closed
1 task

Give contract authors control over optimization passes #169

cmichi opened this issue Feb 4, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cmichi
Copy link
Collaborator

cmichi commented Feb 4, 2021

Motivation

In src/cmd/build.rs we currently pass the number of optimization passes 3 to binaryen by default. However, it is desirable to give contract authors control over this setting. Hence we want to expose it on the cli.

ToDo

  • cargo contract build should have an additional --optimization-passes parameter which makes this variable customizable.
@cmichi cmichi added enhancement New feature or request good first issue Good for newcomers labels Feb 4, 2021
@cmichi cmichi changed the title Give contract authors control over optimization level Give contract authors control over optimization passes Feb 4, 2021
@clearloop
Copy link

Hi @cmichi , we have a modification in #131 related to the opt passes, if there is any plan on the wasm optimization in cargo-contract, please ping us ( @patractlabs )

@ascjones
Copy link
Collaborator

In addition we could allow this to be configurable via a custom section in a contract's Cargo.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants