Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct develop ubuntu distro of stol-j2735 package #12

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Feb 14, 2025

PR Details

Description

Update v2x-ros-conversion node to use correct version of stol-j2735 package including configuring CI/CD scripts for :

  • release
  • feature
  • release-candidate
  • develop

Related GitHub Issue

Related Jira Key

ARC-275

Motivation and Context

See description

How Has This Been Tested?

Local testing of scripts

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

link_directories(
/opt/carma/lib
)
# include_directories(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this commented out code?

Copy link
Contributor

@adev4a adev4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulbourelly999 paulbourelly999 merged commit fc5f9ae into develop Feb 19, 2025
4 checks passed
@paulbourelly999 paulbourelly999 deleted the arc-275-use-updated-develop-stol-j2735 branch February 19, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants