update install_deps for v2x-ros-conversion #256
Conversation
|
This PR requires usdot-fhwa-stol/v2x-ros-conversion#12 to be merged first. |
There was a problem hiding this comment.
Instead of using the install_dependencies.sh script of v2x-ros-conversion I think it may be better to setup our own install_dependencies.sh script for this repo. My thought process is the script only installs a single package currently. If in the future carma-messenger uses more apt packages it seems that it should have it's own script to install them. What do you think?
Makes sense to me, specially as we are migrating packages to debian, sounds like a good idea to keep an install deps script. |
| shift | ||
| shift | ||
| ;; | ||
| -r|--root) |
There was a problem hiding this comment.
Remove root argument since it is not used
|
|
||
| # Install dependencies | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| ${SCRIPT_DIR}/install_dependencies.sh -b $BRANCH -r $dir |
There was a problem hiding this comment.
remove -r argument since it is not used
|
|
||
|
|
||
| # Install dependencies | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" |
There was a problem hiding this comment.
NIT: I don't think you need this. I think you should just be able to call
./install_dependencies.sh ....
PR Details
This PR updates the installation for the stol-j2735 library to use the correct version based on branch and ubuntu distro.
Description
Related GitHub Issue
Related Jira Key
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: