Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: imprve default host for windows, docker and wsl #126

Merged
merged 3 commits into from
Sep 14, 2023
Merged

perf: imprve default host for windows, docker and wsl #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fdd660
perf: imprve default host for windows, docker and wsl
pi0 Sep 14, 2023
07915f0
add exeception for docker and wsl
pi0 Sep 14, 2023
fd57374
fix condition check
pi0 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/_utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { colors } from "consola/utils";
import { consola } from "consola";
import { ListenOptions } from "./types";
import { isWsl } from "./lib/wsl";
import { isDocker } from "./lib/docker";

export function getNetworkInterfaces(includeIPV6?: boolean): string[] {
const addrs = new Set<string>();
Expand Down Expand Up @@ -73,9 +74,9 @@ export function generateURL(
}

export function getDefaultHost(preferPublic?: boolean) {
// Prefer IPV4 stack for Windows and WSL to avoid performance issues
if (process.platform === "win32" || isWsl()) {
return preferPublic ? "0.0.0.0" : "127.0.0.1";
// Prefer default host for docker and wsl
if (isDocker() || isWsl()) {
return "";
}
// For local, use "localhost" to be developer friendly and allow loopback customization}
// For public, use "" to listen on all NIC interfaces (IPV4 and IPV6)
Expand Down Expand Up @@ -135,7 +136,7 @@ const HOSTNAME_RE = /^(?!-)[\d.:A-Za-z-]{1,63}(?<!-)$/;

export function validateHostname(hostname: string, _public: boolean) {
if (hostname && !HOSTNAME_RE.test(hostname)) {
const fallbackHost = _public ? "0.0.0.0" : "127.0.0.1";
const fallbackHost = _public ? "" : "localhost";
consola.warn(
`[listhen] Invalid hostname \`${hostname}\`. Using \`${fallbackHost}\` as fallback.`,
);
Expand Down
4 changes: 3 additions & 1 deletion src/listen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ import {
validateHostname,
} from "./_utils";
import { resolveCertificate } from "./_cert";
import { isWsl } from "./lib/wsl";
import { isDocker } from "./lib/docker";

export async function listen(
handle: RequestListener,
Expand Down Expand Up @@ -76,7 +78,7 @@ export async function listen(
)} with public option disabled.`,
);
listhenOptions.public = false;
} else if (!listhenOptions.public && _anyhost) {
} else if (!listhenOptions.public && _anyhost && !(isWsl() || isDocker())) {
consola.warn(
`[listhen] Trying to listhen on public host ${JSON.stringify(
listhenOptions.hostname,
Expand Down