-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/general improvements #1904
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
- Coverage 94.00% 93.98% -0.02%
==========================================
Files 126 126
Lines 11905 11895 -10
==========================================
- Hits 11191 11180 -11
- Misses 714 715 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how you changed the tables summarizing all the available models, much clearer in my opinion!
Found a typo and a little inconsistency.
* added encode_train_inference to encoders * added generate_fit_predict_encodings to ForecastingModel * simplify TransferrableFut..Model.generatice_predict_encodings * update changelog * Apply suggestions from code review Co-authored-by: madtoinou <[email protected]> * apply suggestions from PR review part 2 --------- Co-authored-by: madtoinou <[email protected]>
Co-authored-by: madtoinou <[email protected]>
Summary
General documentation improvements: