Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use testdata everywhere #311

Merged
merged 5 commits into from
Oct 9, 2020
Merged

Use testdata everywhere #311

merged 5 commits into from
Oct 9, 2020

Conversation

zbraniecki
Copy link
Member

Here's a switch to use testdata for everything.

I'm starting it as draft to think about if I want to add several locales to the selection

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/datetime/benches/datetime.rs is different
  • components/datetime/Cargo.toml is now changed in the branch
  • components/datetime/examples/work_log.rs is different
  • components/datetime/tests/datetime.rs is different
  • components/pluralrules/benches/fixtures/plurals.json is different
  • components/pluralrules/benches/parser.rs is different
  • components/pluralrules/benches/pluralrules.rs is different
  • components/pluralrules/Cargo.toml is now changed in the branch
  • components/pluralrules/examples/elevator_floors.rs is different
  • components/pluralrules/examples/unread_emails.rs is different
  • components/pluralrules/tests/plurals.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@zbraniecki zbraniecki marked this pull request as ready for review October 9, 2020 18:48
@zbraniecki zbraniecki requested review from sffc and a team as code owners October 9, 2020 18:48
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/icu/src/lib.rs is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@zbraniecki zbraniecki mentioned this pull request Oct 9, 2020
Closed
sffc
sffc previously approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some suggestions

@zbraniecki zbraniecki added this to the ICU4X 0.1 milestone Oct 9, 2020
@zbraniecki zbraniecki mentioned this pull request Oct 9, 2020
Closed
sffc
sffc previously approved these changes Oct 9, 2020
View reviewed changes
@zbraniecki zbraniecki merged commit 5f9af94 into unicode-org:master Oct 9, 2020
@zbraniecki zbraniecki deleted the use-testdata branch October 19, 2020 15:49
@sffc sffc linked an issue Oct 20, 2020 that may be closed by this pull request
How to link testdata #317
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ICU4X 0.1
Development

Successfully merging this pull request may close these issues.

How to link testdata
2 participants
@zbraniecki @sffc