Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to link testdata #317

Closed
sffc opened this issue Oct 9, 2020 · 1 comment · Fixed by #311
Closed

How to link testdata #317

sffc opened this issue Oct 9, 2020 · 1 comment · Fixed by #311
Labels
C-data-infra Component: provider, datagen, fallback, adapters C-test-infra Component: Integration test infrastructure T-core Type: Required functionality

Comments

@sffc
Copy link
Member

sffc commented Oct 9, 2020

#306 includes the testdata as:

    let provider = FsDataProvider::try_new("../../resources/testdata/data/json")
        .expect("Loading file from testdata directory");

The crate documentation says:

let data_provider = icu_testdata::get_provider();

Decide what to use in tests and in examples.

@sffc sffc added the discuss Discuss at a future ICU4X-SC meeting label Oct 9, 2020
@zbraniecki
Copy link
Member

I decided to use testdata everywhere in code, and document the use of FsDataProvider in docs, tutorials and wiki.

@zbraniecki zbraniecki removed the discuss Discuss at a future ICU4X-SC meeting label Oct 9, 2020
@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters C-test-infra Component: Integration test infrastructure T-core Type: Required functionality labels Oct 20, 2020
@sffc sffc linked a pull request Oct 20, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters C-test-infra Component: Integration test infrastructure T-core Type: Required functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants