Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused stream code #826

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Clean unused stream code #826

merged 1 commit into from
Nov 30, 2020

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Nov 30, 2020

It was supposed to solve #253 but frontend part for it in #357 was never finished, and backend code produces false positive test failures since day 0. The cost of just having this code around is too high, we'll re-add it in case frontend implementation will be finished.

It was supposed to solve #253 but frontend part for it in
#357 was never finished, and backend code produces false
positive test failures since day 0. The cost of just having
this code around is too high, we'll re-add it in case
frontend implementation will be finished.
@paskal paskal requested a review from umputun November 30, 2020 01:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 390622761

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 83.463%

Files with Coverage Reduction New Missed Lines %
backend/app/notify/notify.go 2 94.29%
Totals Coverage Status
Change from base Build 390570834: -0.1%
Covered Lines: 5244
Relevant Lines: 6283

💛 - Coveralls

@umputun umputun merged commit 4f4c302 into master Nov 30, 2020
@paskal paskal deleted the paskal/clean_stream branch November 30, 2020 23:36
@paskal paskal added this to the v1.7 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants