-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New comment fetch #253
Comments
* add /stream/info as a cheap way to subscribe to comment updates #253 * add check for lastTS change to allow proper info streams in no-cache mode * check write error in info stream and terminate * flaky info stream test * add stream info to readme * separate timeout middleware foe each route's group * debug info on stream close * fix test for streams * stream timeout on inactivity only * throttle streams to 500 * restore common throttle
I have added note: this is not "comment fetch" but a way to get info if new comments were added (or removed) from the thread. This is not websocket either but a long connection with a timeout. |
Hope I'll get the time this weekend |
Do you think we need a way to control stream/no-stream from my side? For example, we can have this streaming optional globally and populate "streams": true/false as a part of |
It's 2k19, and I think it will be good if remark have option to fetch new comments, just like in chat, where you don't have to reload a page to see new comment. Github also shows new comments immediately after it was posted.
So, idea from the design view looks like this:
![screenshot 2019-01-17 at 00 26 13](https://user-images.githubusercontent.com/884649/51280525-e701a180-19f0-11e9-8d9b-4876140d1066.png)
Notice thread margin on the left, and "2 new comments" button on the right, which upon click shows comments which appeared after user loaded the page.
From the backend/frontend side its:
autorefresh
or with valuesoff(default)|socket
or something.off
value can be used to turn off autorefresh, as lot of websocket connections can kill cheap server.Just my 2¢
The text was updated successfully, but these errors were encountered: