show threads

[webkonstantin]

radio-t/radio-t-site#94

@Reeywhaar

[Reeywhaar]

Wow, thank you so much!

At first glimpse I see problem: Comments on level 5 and below should not be indented (think of mobile), yet somehow show that they are replies 🤔

[umputun]

I think the line should be aligned to the left side of the first symbol. I know Reddit does it in the middle of the first one, but they have arrows here.

Comments on level 5 and below should not be indented (think of mobile), yet somehow show that they are replies 🤔

I think the current indication on a deep level is fine but will be nice to fix it to actually jump to the parent comment

[umputun]

this is an example as NYT shows threads

[webkonstantin]

fixed alignment

[umputun]

@sw-double & @Reeywhaar - what is the status of PR? is it still WIP or good to be merged?

[webkonstantin]

not sure that it handles dark theme in an idiomatic way

otherwise LGTM on my end

[umputun]

@sw-double cool, thx!

@Reeywhaar - need your blessing

[Reeywhaar]

I'm working on ui and stream api, plan to end in next 3 hours, then I'll watch this PR.
@umputun hope you don't rush to make it before the show :-)
@sw-double, thank you so much 👍

[umputun]

sure, take your time. thx

[Reeywhaar]

Is it me, or lines color is too active in light theme?

I'd rather mute it to rgba(0,0,0,.07)

... or even to rgba(0,0,0,.05)

... or another variant to make border dotted:

[Reeywhaar]

I'd rather move this selector to comment_theme_dark.scss and make it like

.comment_theme_dark {
  ...
  & ~ .thread {...}
}

[Reeywhaar]

In general I see no crimes here, concise work, @sw-double, thank you, once again! So, @umputun, if you like it then great, I can fix some minor issues myself.

[Reeywhaar]

I think we should make something with mobile layout

[umputun]

Generally, I like it, thx @sw-double . Two issues to address:

1. All internals "levels" don't need any visible thread lines. On such a deep level it is already impossible to understand the tree and adding zebra doesn't make it any better
2. I agree with @Reeywhaar - those lines are too visible. Your dotted variant looks better to me

[Reeywhaar]

I'm afraid without the lines it becomes even more unclear

... I can make level5+ lines even more muted

[umputun]

Is there a reason why 5+ level indentations are any different? Or why we even have any for such deep levels?

[Reeywhaar]

Not sure I follow. 5+ are indented less mainly for mobile and for big discussions. In old version, as you may remember, levels 5+ were unindented at all. Dunno what helps there actually, I think comments this deep are mess no matter what. What do you suggest?

[Reeywhaar]

One another solution is to set min-width on thread, and if some discussiton breaks this limit then we get horizontal scroll

[umputun]

My suggestion is to revert 5+ to unindented

[Reeywhaar]

ok, agree