Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken deps #1396

Merged
merged 2 commits into from
Jul 1, 2022
Merged

fix broken deps #1396

merged 2 commits into from
Jul 1, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jun 30, 2022

The size job failed because this problem. It simply updates packages that couldn't be resolved and packages around in order to have fresh packages for whole eslint ecosystem on the project.

Also removes jest plugin for eslint because it is already included in preact preset https://github.com/preactjs/eslint-config-preact/blob/master/index.js#L27

npm errors CleanShot 2022-06-30 at 11 51 44@2x

FIY Size job will be failing until we have these changes in master because it's running npm install for master as well.

@akellbl4 akellbl4 requested a review from Mavrin June 30, 2022 18:55
@akellbl4 akellbl4 requested a review from umputun as a code owner June 30, 2022 18:55
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1396 (04d4d0b) into master (fa7d5ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1396   +/-   ##
=======================================
  Coverage   51.90%   51.90%           
=======================================
  Files         138      138           
  Lines        2998     2998           
  Branches      695      695           
=======================================
  Hits         1556     1556           
  Misses       1434     1434           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a5c5a4...04d4d0b. Read the comment docs.

@umputun umputun merged commit 5f3206a into master Jul 1, 2022
@umputun umputun deleted the fix-deps branch July 1, 2022 16:13
@paskal paskal added this to the v1.10.2 milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants