Fix email autofill in subscription popup #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akellbl4
force-pushed
the
autofill-email-for-subscription
branch
from
06dddb9 to
4b47343
Compare
Codecov Report
@@ Coverage Diff @@
## master #1394 +/- ##
==========================================
+ Coverage 57.74% 57.88% +0.14%
==========================================
Files 130 130
Lines 2873 2885 +12
Branches 742 741 -1
==========================================
+ Hits 1659 1670 +11
- Misses 1210 1211 +1
Partials 4 4
Continue to review full report at Codecov.
|
akellbl4
commented
Jun 30, 2022
| @@ -31,6 +31,7 @@ import styles from './auth.module.css'; | |||
| export function Auth() { | |||
| const intl = useIntl(); | |||
| const telegramParamsRef = useRef<null | { bot: string; token: string }>(null); | |||
| const emailRef = useRef(''); | |||
There was a problem hiding this comment.
save email between rerenders
Mavrin
previously approved these changes
Jul 1, 2022
akellbl4
force-pushed
the
autofill-email-for-subscription
branch
from
4b47343 to
533c924
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1396
Fixes the first part of #1393
Persist email in local storage for autofill in subscription popup.