Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiSE vs fCoSE usage with groups #308

Closed
ugurdogrusoz opened this issue Nov 18, 2020 · 4 comments
Closed

CiSE vs fCoSE usage with groups #308

ugurdogrusoz opened this issue Nov 18, 2020 · 4 comments
Assignees
Labels
enhancement Enhancement to existing feature

Comments

@ugurdogrusoz
Copy link
Owner

Currently we make use of the CiSE layout only when we apply grouping (e.g. by Louvain clustering) and the user setting is Group by Circles. We should however consistently use CiSE when this setting is Circles during other operations as well. So:

  • On Edit > Add Group for Selected, let's create clustering and apply incremental CiSE if layout is to be applied.

  • Wherever we're to apply layout we should check whether there are any groups in the graph (compounds or circles) and if the grouping exists and the setting is by circles, we should apply CiSE instead of fCoSE.

@ugurdogrusoz ugurdogrusoz added the enhancement Enhancement to existing feature label Nov 18, 2020
canbax added a commit that referenced this issue Nov 30, 2020
@canbax
Copy link
Collaborator

canbax commented Nov 30, 2020

If there is no cluster or just one small cluster I observed that cise works a bit laggy.

In the below image you can see that there is only one small cluster. In the bottom left, you can see that some javascript takes like 1.5 seconds which occurs whenever I run cise layout. If there are lots of clusters I didn't observe that lag.

Screen Shot 2020-11-30 at 17 32 57

@canbax canbax assigned ugurdogrusoz and unassigned canbax Nov 30, 2020
@ugurdogrusoz
Copy link
Owner Author

ugurdogrusoz commented Dec 1, 2020

  • 1. Changing "Group using" choice has no effect on the use of compounds vs. clusters
  • 2. When Circles are in use and I select a group of nodes, some of which are already in a cluster, others not, we should put all of them into a newly created cluster. Currently, those already in a cluster stay in their cluster and we create a new cluster for the others.

@ugurdogrusoz
Copy link
Owner Author

  1. Changing "Group using" from Compound to Circle works fine but not the other way around.

@ugurdogrusoz ugurdogrusoz assigned canbax and unassigned ugurdogrusoz Dec 2, 2020
canbax added a commit that referenced this issue Dec 2, 2020
@canbax canbax assigned ugurdogrusoz and unassigned canbax Dec 2, 2020
@ugurdogrusoz
Copy link
Owner Author

ugurdogrusoz commented Dec 2, 2020

  • 3. I also noticed that "Perform Layout" will not be incremental when using Circles / CiSE (Recalculates Layout).

@ugurdogrusoz ugurdogrusoz assigned canbax and unassigned ugurdogrusoz Dec 2, 2020
canbax added a commit that referenced this issue Dec 3, 2020
@canbax canbax assigned ugurdogrusoz and unassigned canbax Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

No branches or pull requests

2 participants