-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CiSE vs fCoSE usage with groups #308
Labels
enhancement
Enhancement to existing feature
Comments
If there is no cluster or just one small cluster I observed that cise works a bit laggy. In the below image you can see that there is only one small cluster. In the bottom left, you can see that some javascript takes like 1.5 seconds which occurs whenever I run cise layout. If there are lots of clusters I didn't observe that lag. |
|
canbax
added a commit
that referenced
this issue
Dec 1, 2020
canbax
added a commit
that referenced
this issue
Dec 2, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we make use of the CiSE layout only when we apply grouping (e.g. by Louvain clustering) and the user setting is Group by Circles. We should however consistently use CiSE when this setting is Circles during other operations as well. So:
On Edit > Add Group for Selected, let's create clustering and apply incremental CiSE if layout is to be applied.
Wherever we're to apply layout we should check whether there are any groups in the graph (compounds or circles) and if the grouping exists and the setting is by circles, we should apply CiSE instead of fCoSE.
The text was updated successfully, but these errors were encountered: