-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue #11
Comments
Related to this? |
I think this problem is not related to layout-utilities. I made a performance test and I see the below image You can see that |
Looks like the major problem with performance is due to not using the FR grid variant used by other force-directed layout algorithms we have like CoSE. Let's implement FR grid variant. Let's also make sure repulsion forces are not redundantly (twice) calculated for in-circle nodes as we noticed. |
#11 Cooling Factors are decreased There were incorrect and redundant repulsion force calculations for inner nodes, that is fixed
I fixed the in-circle node repulsion force calculation problem but because we developed the expanding circle model based on their moves, as it is approximately halved now, I decreased the escape limit to expand the circle, too. I tested the layouts, however, I'm not sure about the quality. @ugurdogrusoz hocam, could you check the quality? |
Looks reasonable @herencalik. Let's evaluate more carefully after FR grid variant is implemented. |
@canbax The performance should be improved now. |
I see an improvement but I still see a lag around 900-1000 ms. It is not too bad. It just makes a small freezing in the browser. This lag is around 50-100 ms in fcose. |
Can you please provide specific before & after numbers? |
ugurdogrusoz/visuall#308 (comment) here I see it was around 1400-1500 ms. Now it is around 1000 ms. |
Let's sleep on this for a while and see the performance as is. |
According to @canbax When there are no clusters or just a small one, the performance is laggy.
See ugurdogrusoz/visuall#308.
The text was updated successfully, but these errors were encountered: