Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue #11

Open
ugurdogrusoz opened this issue Dec 1, 2020 · 10 comments
Open

Performance issue #11

ugurdogrusoz opened this issue Dec 1, 2020 · 10 comments
Labels
enhancement Enhancement to existing feature

Comments

@ugurdogrusoz
Copy link
Contributor

According to @canbax When there are no clusters or just a small one, the performance is laggy.
See ugurdogrusoz/visuall#308.

@ugurdogrusoz ugurdogrusoz added the enhancement Enhancement to existing feature label Dec 1, 2020
@ugurdogrusoz
Copy link
Contributor Author

Related to this?

@canbax
Copy link
Member

canbax commented Dec 28, 2020

I think this problem is not related to layout-utilities. I made a performance test and I see the below image
image

You can see that calcRepulsionForcestakes too much time here, not the layout-utilities. I also attached the Performance Test file
Profile-20201228T105931.json.zip

@ugurdogrusoz
Copy link
Contributor Author

Looks like the major problem with performance is due to not using the FR grid variant used by other force-directed layout algorithms we have like CoSE. Let's implement FR grid variant.

Let's also make sure repulsion forces are not redundantly (twice) calculated for in-circle nodes as we noticed.

herencalik added a commit that referenced this issue Apr 22, 2021
#11
Cooling Factors are decreased
There were incorrect and redundant repulsion force calculations for inner nodes, that is fixed
@herencalik
Copy link
Contributor

herencalik commented Apr 22, 2021

I fixed the in-circle node repulsion force calculation problem but because we developed the expanding circle model based on their moves, as it is approximately halved now, I decreased the escape limit to expand the circle, too. I tested the layouts, however, I'm not sure about the quality. @ugurdogrusoz hocam, could you check the quality?

@ugurdogrusoz
Copy link
Contributor Author

Looks reasonable @herencalik. Let's evaluate more carefully after FR grid variant is implemented.

@ugurdogrusoz
Copy link
Contributor Author

@canbax The performance should be improved now.

@ugurdogrusoz ugurdogrusoz assigned canbax and unassigned herencalik May 25, 2021
@canbax
Copy link
Member

canbax commented Jun 1, 2021

I see an improvement but I still see a lag around 900-1000 ms. It is not too bad. It just makes a small freezing in the browser. This lag is around 50-100 ms in fcose.

@canbax canbax assigned ugurdogrusoz and unassigned canbax Jun 1, 2021
@ugurdogrusoz
Copy link
Contributor Author

Can you please provide specific before & after numbers?

@ugurdogrusoz ugurdogrusoz assigned canbax and unassigned ugurdogrusoz Jun 1, 2021
@canbax
Copy link
Member

canbax commented Jun 1, 2021

ugurdogrusoz/visuall#308 (comment) here I see it was around 1400-1500 ms. Now it is around 1000 ms.

@canbax canbax assigned ugurdogrusoz and unassigned canbax Jun 1, 2021
@ugurdogrusoz ugurdogrusoz removed their assignment Oct 20, 2021
@ugurdogrusoz
Copy link
Contributor Author

Let's sleep on this for a while and see the performance as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

No branches or pull requests

3 participants