Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme

[SamuelTrahanNOAA]

PR Author Checklist:

• I have linked PR's from all sub-components involved in section below.
• I am confirming reviews are completed in ALL sub-component PR's.
• I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • LOG: committed to repository
• I have added the list of all failed regression tests to "Anticipated changes" section.
• I have filled out all sections of the template.

Description

Inside CCPP, there were several bugs in the error detection in GFS_phys_time_vary.fv3.F90. Errors might go undetected, or may be reported incorrectly. This was uncovered by @hu5970's RRFS runs.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

All issues are in the ccpp-physics repository within the FV3 subcomponent.

• fixes ozinterp and h2ointerp data is read when it is not needed ccpp-physics#108
• fixes The noahmptable.tbl file is mandatory, even for configurations that don't need it. ccpp-physics#107
• fixes GFS_phys_time_vary_init does not report errmsg/errflg correctly due to thread race condition ccpp-physics#105
• fixes incorrect filename in warning message for missing noahmptable.tbl ccpp-physics#104
• fixes FV3_HRRR_c3 suite crashes in c3 calls on Cheyenne with gnu compiler in debug mode. ccpp-physics#101

Subcomponent Pull Requests

• Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme NOAA-EMC/fv3atm#701
• Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme ccpp-physics#106

Blocking Dependencies

None

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Anticipated Changes

Input data

• No changes are expected to input data.

Regression Tests:

• Changes are expected to the following tests:
  • Remove hrrr_gf and hrrr_c3
  • Add hrrr_gf_debug and hrrr_c3_debug (run for both compilers)

Expand for full list in conf format

COMPILE | atm_debug_dyn32 | intel | -DAPP=ATM -DDEBUG=ON -D32BIT=ON -DCCPP_SUITES=FV3_HRRR,FV3_GFS_v16,FV3_GFS_v16_csawmg,FV3_GFS_v16_ras,FV3_GFS_v17_p8,FV3_GFS_v15_thompson_mynn_lam3km,FV3_RAP,FV3_RAP_unified_ugwp,FV3_RAP_cires_ugwp,FV3_RAP_flake,FV3_RAP_clm_lake,FV3_RAP_noah,FV3_RAP_sfcdiff,FV3_RAP_noah_sfcdiff_cires_ugwp,FV3_RRFS_v1beta,FV3_HRRR_c3,FV3_HRRR_gf | - noaacloud  | fv3 |
RUN | hrrr_gf_debug                                     | - noaacloud                  | baseline |
RUN | hrrr_c3_debug                                     | - noaacloud                  | baseline |

COMPILE | atm_dyn32_debug | gnu | -DAPP=ATM -D32BIT=ON -DDEBUG=ON | + hera cheyenne hercules | fv3 |
RUN | hrrr_gf_debug                                     | + hera cheyenne hercules            | baseline |
RUN | hrrr_c3_debug                                     | + hera cheyenne hercules            | baseline |

Libraries

• Not Needed

Code Managers Log

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
  • N/A

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[SamuelTrahanNOAA]

This PR's branch has been merged into #1903

[jkbk2004]

Merged with #1893