Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fv3atm io routines to use same type kind for both axes and data variables #1903

Merged
merged 18 commits into from
Sep 26, 2023

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Sep 13, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

This PR updates fv3atm io routines to use the same data type (float or double) for axes in restart files as data type used for data variables. This will make a temporary fix in restart write routine in the write grid component unnecessary and make everything consistent and restart files written by FMS and write grid component will be identical.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

NOAA-EMC/fv3atm#696

Blocking Dependencies

None

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

atmaero_control_p8
atmaero_control_p8_rad
atmaero_control_p8_rad_micro
atmwav_control_noaero_p8
control_atmwav
control_c384gdas
control_c48
control_p8_faster
control_p8
control_p8_mynn
control_p8_rrtmgp
conus13km_control
cpld_bmark_p8
cpld_control_c192_p8
cpld_control_c48
cpld_control_c96_noaero_p8
cpld_control_ciceC_p8
cpld_control_gfsv17
cpld_control_noaero_p8_agrid
cpld_control_noaero_p8
cpld_control_p8_faster
cpld_control_p8
cpld_control_p8_mixedmode
cpld_control_pdlib_p8
cpld_debug_noaero_p8
cpld_debug_p8
cpld_debug_pdlib_p8
hafs_global_1nest_atm
hafs_global_multiple_4nests_atm
hafs_regional_1nest_atm
hafs_regional_storm_following_1nest_atm
hrrr_c3
hrrr_control_dyn32_phy32
hrrr_control
hrrr_gf
merra2_thompson
rap_control_dyn32_phy32
rap_control_dyn64_phy32
rap_control
rap_sfcdiff
regional_atmaq_debug
regional_atmaq_faster
regional_atmaq
rrfs_v1beta

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DusanJovic-NOAA
Copy link
Collaborator Author

RegressionTests_hera.log

@DusanJovic-NOAA DusanJovic-NOAA added the Baseline Updates Current baselines will be updated. label Sep 14, 2023
@zach1221
Copy link
Collaborator

zach1221 commented Sep 22, 2023

Hey, @BrianCurtis-NOAA . I think we can start testing on this PR.

Edit: Once @DusanJovic-NOAA syncs with develop/resolves conflict.

@zach1221 zach1221 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Sep 22, 2023
@zach1221
Copy link
Collaborator

Some problems with jenkins-ci connecting to EC2 instance, so running the ORTs manually on Hera in the meantime.

@SamuelTrahanNOAA
Copy link
Collaborator

I've tested #1893 on Hera using this PR as the baseline. (That's the 20230922 baseline.) That means #1893 should be ready to go when you merge this.

@jkbk2004
Copy link
Collaborator

@SamuelTrahanNOAA thanks for the note! @BrianCurtis-NOAA acorn is running on this pr, right?

@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA we can merge with fv3 hash update.

@jkbk2004 jkbk2004 merged commit f7a94ce into ufs-community:develop Sep 26, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the axis_type branch September 27, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants