-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fv3atm io routines to use same type kind for both axes and data variables #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Hey, @BrianCurtis-NOAA . I think we can start testing on this PR. Edit: Once @DusanJovic-NOAA syncs with develop/resolves conflict. |
Some problems with jenkins-ci connecting to EC2 instance, so running the ORTs manually on Hera in the meantime. |
This was referenced Sep 25, 2023
Closed
@SamuelTrahanNOAA thanks for the note! @BrianCurtis-NOAA acorn is running on this pr, right? |
6 tasks
@DusanJovic-NOAA we can merge with fv3 hash update. |
BrianCurtis-NOAA
approved these changes
Sep 26, 2023
sadeghitabas
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Baseline Updates
Current baselines will be updated.
jenkins-ci
Jenkins CI: ORT build/test on docker container
Ready for Commit Queue
The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Author Checklist:
Description
This PR updates fv3atm io routines to use the same data type (float or double) for axes in restart files as data type used for data variables. This will make a temporary fix in restart write routine in the write grid component unnecessary and make everything consistent and restart files written by FMS and write grid component will be identical.
Linked Issues and Pull Requests
Associated UFSWM Issue to close
Subcomponent Pull Requests
NOAA-EMC/fv3atm#696
Blocking Dependencies
None
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
atmaero_control_p8
atmaero_control_p8_rad
atmaero_control_p8_rad_micro
atmwav_control_noaero_p8
control_atmwav
control_c384gdas
control_c48
control_p8_faster
control_p8
control_p8_mynn
control_p8_rrtmgp
conus13km_control
cpld_bmark_p8
cpld_control_c192_p8
cpld_control_c48
cpld_control_c96_noaero_p8
cpld_control_ciceC_p8
cpld_control_gfsv17
cpld_control_noaero_p8_agrid
cpld_control_noaero_p8
cpld_control_p8_faster
cpld_control_p8
cpld_control_p8_mixedmode
cpld_control_pdlib_p8
cpld_debug_noaero_p8
cpld_debug_p8
cpld_debug_pdlib_p8
hafs_global_1nest_atm
hafs_global_multiple_4nests_atm
hafs_regional_1nest_atm
hafs_regional_storm_following_1nest_atm
hrrr_c3
hrrr_control_dyn32_phy32
hrrr_control
hrrr_gf
merra2_thompson
rap_control_dyn32_phy32
rap_control_dyn64_phy32
rap_control
rap_sfcdiff
regional_atmaq_debug
regional_atmaq_faster
regional_atmaq
rrfs_v1beta
Libraries
Code Managers Log
Testing Log: