update library and remove yaFyaml #1425
Conversation
|
@junwang-noaa there is crtm-2.4.0 installation issue on gaea: hpc-stack issue #487. Except crtm-2.4.0, we can combine with fms-2022.03. Also, we can combine #1418 and #1431. |
|
@jkbk2004 Can you confirm crtm 2.4.0/g2tmpl 1.10.2 are available on all the R&D platforms? @BrianCurtis-NOAA do you have g2tmpl 1.10.2 on wcoss2? We can update fms/2022.03. But we need to update dycore update to get mixed mode code changes in. |
Yes |
|
so fms-2022.03 and gtmpl-1.10.2 are ready. But crtm-2.4.0 is not ready on gaea. Should we go ahead to update only those two fms-2022.03 and gtmpl-1.10.2 ? |
|
What happened with crtm 2.4.0 on gaea? Thanks
…On Fri, Sep 23, 2022 at 1:52 PM JONG KIM ***@***.***> wrote:
so fms-2022.03 and gtmpl-1.10.2 are ready. But crtm-2.4.0 is not ready on
gaea. Should we go ahead to update only those two fms-2022.03 and
gtmpl-1.10.2 ?
—
Reply to this email directly, view it on GitHub
<#1425 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPX77WAIZY47CIFAT3V7XU63ANCNFSM6AAAAAAQPXAYSA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
crtm-v2.4.0 introduces netcdf_config function in cmake. On gaea, it catches NetCDF_PARALLEL /MPI requirement. We have to turn if off. With that, we installed crtm-2.4.0 installed ok. I confirmed the baseline is ok with the new crtm. I will leave a note to the hpc-stack issue to see if we have to report to nceplib/crtm repo. BTW, fms-2022.03, g2tmpl-1.10.2, and crtm-v2.4.0 are ready on all machines. @BrianCurtis-NOAA can you confirm crtm-v2.4.0 on wcoss2? |
|
@BrianCurtis-NOAA Is fms 2022.03 available on wcoss2? |
|
@jkbk2004 @junwang-noaa fms/2022.03 and crtm/2.4.0 are both on WCOSS2 |
|
@jkbk2004 @BrianCurtis-NOAA The fms and crtm libraries are updated. |
|
@junwang-noaa I think we are ready to work on this PR. But we want to combine Sam's #1431 and Ratko's #1418. You are too busy to follow up PRs. We can ask Sam to merge in this PR and Ratko's. What do you think? |
|
It works for me. Thank you! |
|
@junwang-noaa @BrianCurtis-NOAA Sam already combined #1418 to #1437. Let's work start testing this PR alone. We can combine Ratko's #1418 to Dusan's #1434 later. |
|
I am updating the commit queue table now. |
|
@BrianCurtis-NOAA I will go ahead to test this PR from hera.- Note that we are not combining with other PRs. |
|
Every regression test on WCOSS2 failed comparison. |
|
@junwang-noaa Could the bump for crtm version or the removal of yaFyaml caused baselines to change? |
I manually was testing cpld_control_p8 for this PR on orion. It was working ok. Let's see how hera tests go. |
|
@jkbk2004 @LinZhu-NOAA @BinLiu-NOAA I am doing some testing, I think it is g2tmpl update not crtm that causes the different. Will update the code when the testing is done. |
|
Yes, we need more time. We are moving to #1438. |
|
@junwang-noaa #1438 needs additional review. We can start working on this again. Sorry for flipping PR schedules. As orion is down today and tomorrow, we can have time to finish tests. |
|
I reverted the g2tmpl version, full RT passed on hera with intel (no results change) |
|
WCOSS2: rap_flake_debug wallclock ran too long, re-running. |
|
Automated RT Failure Notification |
|
@junwang-noaa we covered RT runs ok even though Orion is down today. You already tested. We can start merging process. |
jkbk2004
requested review from
ChunxiZhang-NOAA,
DeniseWorthen,
BrianCurtis-NOAA and
jkbk2004
|
@junwang-noaa We should close the issue associated with this PR when it's merged, but since we didn't fix all of the issue (other libraries), could you create an issue for the libraries that we missed? |
|
we will follow up g2tmpl-1.10.2 issue with issue1441 |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR is to 1) update upp and related libraries. g2tmpl/crtm. 2) remove yaFyaml library from GOCART. 3) fix diag_time when restart at non-multiple of fhzero.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Closes #1422
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs