-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RRFS-A to weekly tests #1418
Conversation
@RatkoVasic-NOAA If possible, can you create pr to @DusanJovic-NOAA 's fork branch to combine this pr to #1434 ? |
@RatkoVasic-NOAA ignore my previous message. We will commit this PR on Monday. |
@BrianCurtis-NOAA a new INPUT directory was added on Hera under /scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/input-data-20220414/fv3_regional_rrfs_a @RatkoVasic-NOAA This new input file will be used in weekly test. So no baseline change to existing regression tests, right? |
@RatkoVasic-NOAA Do you have a log file of this RT passing? @jkbk2004 I am not sure this needs full RT testing if we're just adding a test to the weekly RT. |
No, weekly test results (logs) are not stored in repository. |
I think we can do a quick sanity run with a machine like orion. Once we confirm with the sanity run, we should be ok to merge in. |
@RatkoVasic-NOAA i think |
Yes, it runs on Hera only. |
Run on Hera |
I just let it run on Hera and it is failing in compilation:
|
@BrianCurtis-NOAA @jkbk2004 |
rsynced ok new input files of fv3_regional_rrfs_a to all machines |
@jkbk2004 @BrianCurtis-NOAA
|
All sounds good. This PR is ready. |
@binli2337 @BrianCurtis-NOAA We can start merging in this pr. I will close issue #1417. Go ahead to leave final review and approve. |
@jkbk2004 you can use the top of the PR to add a "closes #1417" so the PR will automatically close that issue once merged. |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Issue Add RRFS-A to weekly tests #1417
[-] Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
[+] New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Already added it to Hera:
/scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/input-data-20220414/fv3_regional_rrfs_a/INPUT/
(need to propagate to all other machines, although not in use)
Code managers please synchronize input-data-20220414 from Hera to all other supported machines.
Instructions: All subsequent sections of text should be filled in as appropriate.
Adding new test, can be merged with other PR's. Only one file changed (rt_weekly.conf) and 6 new files added to tests directory.
Description
Adding new test to Hera machine, weekly tests
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies