Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RRFS-A to weekly tests #1418

Merged
merged 7 commits into from
Oct 4, 2022
Merged

Add RRFS-A to weekly tests #1418

merged 7 commits into from
Oct 4, 2022

Conversation

RatkoVasic-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA commented Sep 14, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.
    Issue Add RRFS-A to weekly tests #1417

  • [-] Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • [+] New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
    Already added it to Hera:
    /scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/input-data-20220414/fv3_regional_rrfs_a/INPUT/
    (need to propagate to all other machines, although not in use)
    Code managers please synchronize input-data-20220414 from Hera to all other supported machines.

Instructions: All subsequent sections of text should be filled in as appropriate.

Adding new test, can be merged with other PR's. Only one file changed (rt_weekly.conf) and 6 new files added to tests directory.

Description

Adding new test to Hera machine, weekly tests

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

@jkbk2004
Copy link
Collaborator

@RatkoVasic-NOAA If possible, can you create pr to @DusanJovic-NOAA 's fork branch to combine this pr to #1434 ?

@jkbk2004
Copy link
Collaborator

@RatkoVasic-NOAA ignore my previous message. We will commit this PR on Monday.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 3, 2022

@BrianCurtis-NOAA a new INPUT directory was added on Hera under /scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/input-data-20220414/fv3_regional_rrfs_a @RatkoVasic-NOAA This new input file will be used in weekly test. So no baseline change to existing regression tests, right?

@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change New Input Data Req'd This PR requires new data to be sync across platforms labels Oct 3, 2022
@BrianCurtis-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA Do you have a log file of this RT passing?

@jkbk2004 I am not sure this needs full RT testing if we're just adding a test to the weekly RT.

@RatkoVasic-NOAA
Copy link
Collaborator Author

@RatkoVasic-NOAA Do you have a log file of this RT passing?

@jkbk2004 I am not sure this needs full RT testing if we're just adding a test to the weekly RT.

No, weekly test results (logs) are not stored in repository.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 3, 2022

I think we can do a quick sanity run with a machine like orion. Once we confirm with the sanity run, we should be ok to merge in.

@BrianCurtis-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA i think ./rt.sh -e -n regional_rrfs_a > rtn.out 2>&1 & might work? I assume you've run it successfully beforehand, so Jong's sanity check should be OK.

@RatkoVasic-NOAA
Copy link
Collaborator Author

Yes, it runs on Hera only.

@BrianCurtis-NOAA
Copy link
Collaborator

I think we can do a quick sanity run with a machine like orion. Once we confirm with the sanity run, we should be ok to merge in.

Run on Hera

@RatkoVasic-NOAA
Copy link
Collaborator Author

RatkoVasic-NOAA commented Oct 3, 2022

I just let it run on Hera and it is failing in compilation:

CMake Error at CMakeLists.txt:119 (find_package):
  By not providing "FindNetCDF.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "NetCDF", but
  CMake did not find one.

  Could not find a package configuration file provided by "NetCDF" (requested
  version 4.7.4) with any of the following names:

    NetCDFConfig.cmake
    netcdf-config.cmake

  Add the installation prefix of "NetCDF" to CMAKE_PREFIX_PATH or set
  "NetCDF_DIR" to a directory containing one of the above files.  If "NetCDF"
  provides a separate development package or SDK, be sure it has been
  installed.

@RatkoVasic-NOAA
Copy link
Collaborator Author

RatkoVasic-NOAA commented Oct 3, 2022

@BrianCurtis-NOAA @jkbk2004
I ran it from old directory (non updated). Now test IS running on Hera,
Hera:/scratch2/NCEPDEV/fv3-cam/Ratko.Vasic/wrk/RRFS/yyy/tests

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 3, 2022

rsynced ok new input files of fv3_regional_rrfs_a to all machines

@RatkoVasic-NOAA
Copy link
Collaborator Author

@jkbk2004 @BrianCurtis-NOAA
Test passed on Hera:

Hera:/scratch2/NCEPDEV/fv3-cam/Ratko.Vasic/wrk/RRFS/yyy/tests>cat RegressionTests_weekly_hera.intel.log
Mon Oct  3 20:07:21 UTC 2022
Start Regression test

Compile 001 elapsed time 321 seconds. -DAPP=ATM -DCCPP_SUITES=FV3_HRRR -D32BIT=ON -DMPI=ON -DCMAKE_BUILD_TYPE=Release

  0: The total amount of wall time                        = 540.111654
  0: The maximum resident set size (KB)                   = 3168296

Test 001 regional_rrfs_a RUN_SUCCESS


REGRESSION TEST WAS SUCCESSFUL
Mon Oct  3 20:33:57 UTC 2022
Elapsed time: 00h:26m:36s. Have a nice day!

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 3, 2022

All sounds good. This PR is ready.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 4, 2022

@binli2337 @BrianCurtis-NOAA We can start merging in this pr. I will close issue #1417. Go ahead to leave final review and approve.

@BrianCurtis-NOAA
Copy link
Collaborator

@binli2337 @BrianCurtis-NOAA We can start merging in this pr. I will close issue #1417. Go ahead to leave final review and approve.

@jkbk2004 you can use the top of the PR to add a "closes #1417" so the PR will automatically close that issue once merged.

@jkbk2004 jkbk2004 merged commit 14db6bb into ufs-community:develop Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Input Data Req'd This PR requires new data to be sync across platforms No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RRFS-A to weekly tests
4 participants