[ens_design_RRFS] Verification changes to split into gen-ens-prod and ensemble-stat #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleharrold
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
jwolff-ncar and
dmwright526
as code owners
jwolff-ncar
approved these changes
Apr 18, 2022
| @@ -112,9 +112,9 @@ NUM_PAD=${NDIGITS_ENSMEM_NAMES} | |||
| # | |||
|
|
|||
| if [ ${VAR} == "APCP" ]; then | |||
| LOG_SUFFIX=ensgrid_${CDATE}_${VAR}_${ACCUM}h | |||
There was a problem hiding this comment.
I am sure there is a good reason, but just curious whey the ensgrid went away here and two lines below?
There was a problem hiding this comment.
Good question -- since we run gen-ens-prod and ensemble-stat via exregional_run_ensgridvx.sh, I changed the log suffix logic. Now in the gen-ens-prod METplus conf files, I added gep_ to the LOG_SUFFIX and in ensmeble-stat, I added es_ to the LOG_SUFFIX in gen-ens-prod.
|
I am going to close this PR and reopen another PR that contains both the gen-ens-prod changes AND changes for users providing the input directory of model data and the output directory of MET output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
In METv10.1, the ensemble-stat tool has been split into two distinct tools: gen-ens-prod (new tool; creates ensemble products) and ensemble-stat (calculates ensemble stats). These changes break out the current functionality (solely using ensemble-stat) to use both gen-ens-prod and ensemble-stat. Note, this PR is for the ens_design_RRFS branch.
TESTS CONDUCTED:
Ran test case (2019061500) with GFSv15.2 physics suite for a 3 member (SPPT) ensemble and compared baseline/current capability to new capability to show results are the same using the gen-ens-prod tool.
DEPENDENCIES:
None.
DOCUMENTATION:
When gen-ens-prod capability is included in develop, the documentation will be updated accordingly.
ISSUE (optional):
Issue #709
CONTRIBUTORS (optional):
@jwolff-ncar @evankalina