Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdas_init utility bug fix #912

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Mar 8, 2024

DESCRIPTION OF CHANGES:

When using warm restart files as input to the chgres step (v15/GDAS and v16 retro/GDAS options), it would fail because it was reading from the wrong input data orography directory. Update the scripts to point to the correct directory.

TESTS CONDUCTED:

Two test cases were done on Hera, Jet and WCOSS2.

  • Test 1

    • 2020/12/20/12z cycle
    • CDUMP=GDAS
    • use_v16retro=no
  • Test 2

    • 2019/12/20/12
    • CDUMP=GDAS
    • use_v16retro=yes

Both tests completed normally and produce the required coldstart files.

The 's4' scripts were tested by @DavidHuber-NOAA.

DOCUMENTATION:

N/A

ISSUE:

Fixes #908.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@CoryMartin-NOAA tested the branch on the case that was failing for him. It worked.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review March 8, 2024 20:56
Copy link
Collaborator

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @GeorgeGayno-NOAA !

Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a try out on Jet and was able to create ICs. Everything looks good. Thanks!

@GeorgeGayno-NOAA
Copy link
Collaborator Author

I gave this a try out on Jet and was able to create ICs. Everything looks good. Thanks!

Thanks, can you also try on 's4'? I don't have access to that machine.

@DavidHuber-NOAA
Copy link
Collaborator

Sure, I'll let you know how that goes.

Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 216152f into ufs-community:develop Mar 13, 2024
4 checks passed
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the bugfix/gi branch April 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gdas_init routine fails when processing GDAS v15 data
3 participants